Skip to content

Commit 1604a07

Browse files
sorrisonstephenfin
authored andcommitted
Fix up mypy errors
Unused "type: ignore" comment [unused-ignore] causing pep8 job to fail Change-Id: I65a87680dad7d41c773f65801616c9814c2fa91d Signed-off-by: Sam Morrison <sorrison@gmail.com>
1 parent c193741 commit 1604a07

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

openstackclient/common/project_cleanup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
105105
project = identity_client.find_project(
106106
name_or_id=parsed_args.project, ignore_missing=False
107107
)
108-
# FIXME(stephenfin): The type in SDK is wrong
109-
connection = connection.connect_as_project(project) # type: ignore
108+
connection = connection.connect_as_project(project)
110109

111110
if connection:
112111
status_queue: queue.Queue[Any] = queue.Queue()

openstackclient/volume/v2/volume_snapshot.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,9 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
231231
snapshot_id = volume_client.find_snapshot(
232232
snapshot, ignore_missing=False
233233
).id
234-
# FIXME(stephenfin): This parameter is missing from sdk
235-
# https://review.opendev.org/c/openstack/openstacksdk/+/984529
236234
volume_client.delete_snapshot(
237235
snapshot_id,
238-
force=parsed_args.force, # type: ignore
236+
force=parsed_args.force,
239237
)
240238
except Exception as e:
241239
result += 1

0 commit comments

Comments
 (0)