🐛 Fix race condition in e2e code coverage collection (#2644)

* Fix race condition in e2e coverage collection

kubectl scale --replicas=0 is non-blocking and returns as soon as
the API server accepts the change, not when pods have terminated.
The existing wait on the copy pod was a no-op since it was already
running. This meant kubectl cp could run before manager pods had
terminated and flushed coverage data to the PVC.

Wait for each deployment's .status.replicas to reach 0 before
copying, ensuring the Go coverage runtime has written its data.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix race condition in e2e coverage collection

kubectl scale --replicas=0 is non-blocking and returns as soon as
the API server accepts the change, not when pods have terminated.
The existing wait on the copy pod was a no-op since it was already
running. This meant kubectl cp could run before manager pods had
terminated and flushed coverage data to the PVC.

Wait for manager pods to be deleted before copying, ensuring the
Go coverage runtime has written its data on process exit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: pedjak

hack/test/e2e-coverage.sh

@@ -22,8 +22,9 @@ rm -rf ${COVERAGE_DIR} && mkdir -p ${COVERAGE_DIR}
 kubectl -n "$OPERATOR_CONTROLLER_NAMESPACE" scale deployment/"$OPERATOR_CONTROLLER_MANAGER_DEPLOYMENT_NAME" --replicas=0
 kubectl -n "$CATALOGD_NAMESPACE" scale deployment/"$CATALOGD_MANAGER_DEPLOYMENT_NAME" --replicas=0
 
-# Wait for the copy pod to be ready
-kubectl -n "$OPERATOR_CONTROLLER_NAMESPACE" wait --for=condition=ready pod "$COPY_POD_NAME"
+# Wait for manager pods to terminate so coverage data is flushed to the PVC
+kubectl -n "$OPERATOR_CONTROLLER_NAMESPACE" wait --for=delete pods -l control-plane="$OPERATOR_CONTROLLER_MANAGER_DEPLOYMENT_NAME" --timeout=60s
+kubectl -n "$CATALOGD_NAMESPACE" wait --for=delete pods -l control-plane="$CATALOGD_MANAGER_DEPLOYMENT_NAME" --timeout=60s
 
 # Copy the coverage data from the temporary pod
 kubectl -n "$OPERATOR_CONTROLLER_NAMESPACE" cp "$COPY_POD_NAME":/e2e-coverage/ "$COVERAGE_DIR"