test: invert context of when basic auth is requested without username AND password

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIAuthBasicAuthTestCase.inc

@@ -33,16 +33,16 @@ class APIAuthBasicAuthTestCase extends TestCase {
         $auth = new BasicAuth();
         $this->assert_is_false($auth->is_requested());
 
-        # Ensure is_requested() returns true if either a basic username or password are specified
+        # Ensure is_requested() returns false if either a basic username or password are specified
         $_SERVER['PHP_AUTH_USER'] = 'admin';
         $_SERVER['PHP_AUTH_PW'] = null;
         $auth = new BasicAuth();
-        $this->assert_is_true($auth->is_requested());
+        $this->assert_is_false($auth->is_requested());
         $_SERVER['PHP_AUTH_USER'] = null;
         $_SERVER['PHP_AUTH_PW'] = 'pfsense';
-        $this->assert_is_true($auth->is_requested());
+        $this->assert_is_false($auth->is_requested());
         $_SERVER['PHP_AUTH_USER'] = 'admin';
         $_SERVER['PHP_AUTH_PW'] = 'pfsense';
-        $this->assert_is_true($auth->is_requested());
+        $this->assert_is_false($auth->is_requested());
     }
 }