RdKafka; Replace composer-modifying for testing with --ignore-platform-req argument

maartenderie · maartenderie · commit 993f6c113c99 · 2021-10-29T15:03:12.000+02:00
diff --git a/pkg/rdkafka/.github/workflows/ci.yml b/pkg/rdkafka/.github/workflows/ci.yml
@@ -22,8 +22,8 @@ jobs:
           php-version: ${{ matrix.php }}
           coverage: none
 
-      - run: php Tests/fix_composer_json.php
-
       - uses: "ramsey/composer-install@v1"
+        with: # ext-rdkafka not needed for tests, and a pain to install on CI;
+          composer-options: "--ignore-platform-req=ext-rdkafka"
 
       - run: vendor/bin/phpunit --exclude-group=functional
diff --git a/pkg/rdkafka/Tests/bootstrap.php b/pkg/rdkafka/Tests/bootstrap.php
@@ -12,5 +12,8 @@
     }
 }
 
+// Pretend that a high version was installed, opposed to 0.8.5 from kwn/php-rdkafka-stubs
+const RD_KAFKA_VERSION = 42424242;
+
 include_once $kafkaStubsDir.'/stubs/constants.php';
 include_once $kafkaStubsDir.'/stubs/functions.php';
diff --git a/pkg/rdkafka/Tests/fix_composer_json.php b/pkg/rdkafka/Tests/fix_composer_json.php

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,8 @@`
`12`	`12`	`}`
`13`	`13`	`}`
`14`	`14`
	`15`	`+// Pretend that a high version was installed, opposed to 0.8.5 from kwn/php-rdkafka-stubs`
	`16`	`+const RD_KAFKA_VERSION = 42424242;`
	`17`	`+`
`15`	`18`	`include_once $kafkaStubsDir.'/stubs/constants.php';`
`16`	`19`	`include_once $kafkaStubsDir.'/stubs/functions.php';`