MoLoader::read() does never return false

devnix · devnix · commit 19c8de224cf8 · 2025-04-20T13:43:34.000+02:00
diff --git a/src/Loader/MoLoader.php b/src/Loader/MoLoader.php
@@ -125,9 +125,7 @@ private function seekTo(int $position): void
 
     private function readInt(string $byteOrder): int
     {
-        if (($read = $this->read(4)) === false) {
-            return 0;
-        }
+        $read = $this->read(4);
 
         $read = (array) unpack($byteOrder, $read);
 

Original file line number	Diff line number	Diff line change
`@@ -125,9 +125,7 @@ private function seekTo(int $position): void`
`125`	`125`
`126`	`126`	`private function readInt(string $byteOrder): int`
`127`	`127`	`{`
`128`		`- if (($read = $this->read(4)) === false) {`
`129`		`- return 0;`
`130`		`- }`
	`128`	`+ $read = $this->read(4);`
`131`	`129`
`132`	`130`	`$read = (array) unpack($byteOrder, $read);`
`133`	`131`