Skip to content

Commit b657af2

Browse files
authored
Merge pull request #348 from iMattPro/updates
Some small updates
2 parents df382e1 + 308d965 commit b657af2

3 files changed

Lines changed: 34 additions & 18 deletions

File tree

.github/workflows/tests.yml

Lines changed: 32 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,26 @@ on:
2121
jobs:
2222
# START Basic Checks Job (EPV, code sniffer, images check, etc.)
2323
basic-checks:
24-
runs-on: ubuntu-18.04
24+
runs-on: ubuntu-20.04
2525
strategy:
2626
matrix:
2727
include:
28-
- php: '7.1'
28+
- php: '7.2'
2929
db: "none"
3030
NOTESTS: 1
3131

3232
name: PHP ${{ matrix.php }} - ${{ matrix.db }}
3333

3434
steps:
3535
- name: Checkout phpBB
36-
uses: actions/checkout@v2
36+
uses: actions/checkout@v3
3737
with:
3838
repository: phpbb/phpbb
3939
ref: ${{ env.PHPBB_BRANCH }}
4040
path: phpBB3
4141

4242
- name: Checkout extension
43-
uses: actions/checkout@v2
43+
uses: actions/checkout@v3
4444
with:
4545
path: phpBB3/phpBB/ext/${{ env.EXTNAME }}
4646

@@ -89,7 +89,7 @@ jobs:
8989

9090
# START MySQL and MariaDB Job
9191
mysql-tests:
92-
runs-on: ubuntu-18.04
92+
runs-on: ubuntu-20.04
9393
strategy:
9494
matrix:
9595
include:
@@ -123,6 +123,8 @@ jobs:
123123
db: "mysql:5.7"
124124
- php: '8.1'
125125
db: "mysql:5.7"
126+
- php: '8.2'
127+
db: "mysql:5.7"
126128

127129
name: PHP ${{ matrix.php }} - ${{ matrix.db_alias != '' && matrix.db_alias || matrix.db }}
128130

@@ -152,14 +154,14 @@ jobs:
152154

153155
steps:
154156
- name: Checkout phpBB
155-
uses: actions/checkout@v2
157+
uses: actions/checkout@v3
156158
with:
157159
repository: phpbb/phpbb
158160
ref: ${{ env.PHPBB_BRANCH }}
159161
path: phpBB3
160162

161163
- name: Checkout extension
162-
uses: actions/checkout@v2
164+
uses: actions/checkout@v3
163165
with:
164166
path: phpBB3/phpBB/ext/${{ env.EXTNAME }}
165167

@@ -168,7 +170,7 @@ jobs:
168170
MATRIX_DB: ${{ matrix.db }}
169171
run: |
170172
db=$(echo "${MATRIX_DB%%:*}")
171-
echo "::set-output name=db::$db"
173+
echo "db=$db" >> $GITHUB_OUTPUT
172174
173175
- name: Setup PHP
174176
uses: shivammathur/setup-php@v2
@@ -205,7 +207,7 @@ jobs:
205207

206208
# START PostgreSQL Job
207209
postgres-tests:
208-
runs-on: ubuntu-18.04
210+
runs-on: ubuntu-20.04
209211
strategy:
210212
matrix:
211213
include:
@@ -221,6 +223,20 @@ jobs:
221223
db: "postgres:12"
222224
- php: '7.1'
223225
db: "postgres:13"
226+
- php: '7.2'
227+
db: "postgres:13"
228+
- php: '7.3'
229+
db: "postgres:13"
230+
- php: '7.4'
231+
db: "postgres:13"
232+
- php: '8.0'
233+
db: "postgres:12"
234+
- php: '8.0'
235+
db: "postgres:13"
236+
- php: '8.1'
237+
db: "postgres:14"
238+
- php: '8.2'
239+
db: "postgres:14"
224240

225241
name: PHP ${{ matrix.php }} - ${{ matrix.db }}
226242

@@ -252,14 +268,14 @@ jobs:
252268

253269
steps:
254270
- name: Checkout phpBB
255-
uses: actions/checkout@v2
271+
uses: actions/checkout@v3
256272
with:
257273
repository: phpbb/phpbb
258274
ref: ${{ env.PHPBB_BRANCH }}
259275
path: phpBB3
260276

261277
- name: Checkout extension
262-
uses: actions/checkout@v2
278+
uses: actions/checkout@v3
263279
with:
264280
path: phpBB3/phpBB/ext/${{ env.EXTNAME }}
265281

@@ -268,7 +284,7 @@ jobs:
268284
MATRIX_DB: ${{ matrix.db }}
269285
run: |
270286
db=$(echo "${MATRIX_DB%%:*}")
271-
echo "::set-output name=db::$db"
287+
echo "db=$db" >> $GITHUB_OUTPUT
272288
273289
- name: Setup PHP
274290
uses: shivammathur/setup-php@v2
@@ -305,7 +321,7 @@ jobs:
305321

306322
# START Other Tests Job (SQLite 3 and mssql)
307323
other-tests:
308-
runs-on: ubuntu-18.04
324+
runs-on: ubuntu-20.04
309325
strategy:
310326
matrix:
311327
include:
@@ -347,14 +363,14 @@ jobs:
347363

348364
steps:
349365
- name: Checkout phpBB
350-
uses: actions/checkout@v2
366+
uses: actions/checkout@v3
351367
with:
352368
repository: phpbb/phpbb
353369
ref: ${{ env.PHPBB_BRANCH }}
354370
path: phpBB3
355371

356372
- name: Checkout extension
357-
uses: actions/checkout@v2
373+
uses: actions/checkout@v3
358374
with:
359375
path: phpBB3/phpBB/ext/${{ env.EXTNAME }}
360376

@@ -368,7 +384,7 @@ jobs:
368384
else
369385
db=$(echo "${MATRIX_DB%%:*}")
370386
fi
371-
echo "::set-output name=db::$db"
387+
echo "db=$db" >> $GITHUB_OUTPUT
372388
373389
- name: Setup PHP
374390
uses: shivammathur/setup-php@v2

controller/main_controller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,6 @@ public function display()
173173
));
174174

175175
// Send all data to the template file
176-
return $this->helper->render('boardrules_controller.html', $this->lang->lang('BOARDRULES'));
176+
return $this->helper->render('@phpbb_boardrules/boardrules_controller.html', $this->lang->lang('BOARDRULES'));
177177
}
178178
}

tests/controller/main_controller_test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class main_controller_test extends \phpbb_test_case
2020
public function display_data()
2121
{
2222
return array(
23-
array(200, 'boardrules_controller.html'),
23+
array(200, '@phpbb_boardrules/boardrules_controller.html'),
2424
);
2525
}
2626

0 commit comments

Comments
 (0)