Skip to content

Commit 2cb1c26

Browse files
committed
Clean up
1 parent f533603 commit 2cb1c26

2 files changed

Lines changed: 6 additions & 11 deletions

File tree

language/en/googleanalytics_acp.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
//
3939

4040
$lang = array_merge($lang, array(
41-
'ACP_GOOGLEANALYTICS' => 'Google Analytics',
42-
'ACP_GOOGLEANALYTICS_ID' => 'Google Analytics ID',
43-
'ACP_GOOGLEANALYTICS_ID_EXPLAIN' => 'Enter your Google Analytics ID code, e.g.: <samp>UA-0000000-00</samp>.<br /><br />Google Analytics can track your registered users across multiple devices and sessions, for a more accurate user count in your reports. To enable this enhanced functionality it must be configured in your Google Analytics account. <a href="https://support.google.com/analytics/answer/3123666">Click for more information</a>.',
44-
'ACP_GOOGLEANALYTICS_ID_INVALID' => '“%s” is not a valid Google Analytics ID code.<br />It should be in the form “UA-0000000-00”.',
41+
'ACP_GOOGLEANALYTICS' => 'Google Analytics',
42+
'ACP_GOOGLEANALYTICS_ID' => 'Google Analytics ID',
43+
'ACP_GOOGLEANALYTICS_ID_EXPLAIN' => 'Enter your Google Analytics ID code, e.g.: <samp>UA-0000000-00</samp>.<br /><br />Google Analytics can track your registered users across multiple devices and sessions, for a more accurate user count in your reports. To enable this enhanced functionality User ID tracking must be configured in your Google Analytics account. <a href="https://support.google.com/analytics/answer/3123666">Click for more information</a>.',
44+
'ACP_GOOGLEANALYTICS_ID_INVALID' => '“%s” is not a valid Google Analytics ID code.<br />It should be in the form “UA-0000000-00”.',
4545
));

tests/event/listener_test.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,9 @@ public function setUp()
4040
$phpbb_extension_manager = new \phpbb_mock_extension_manager($phpbb_root_path);
4141

4242
// Load/Mock classes required by the event listener class
43-
$this->config = new \phpbb\config\config(array(
44-
'googleanalytics_id' => 'UA-000000-01',
45-
'googleanalytics_track_user_id' => 1,
46-
));
47-
43+
$this->config = new \phpbb\config\config(array('googleanalytics_id' => 'UA-000000-01'));
4844
$this->template = $this->getMockBuilder('\phpbb\template\template')
4945
->getMock();
50-
5146
$this->user = new \phpbb\user('\phpbb\datetime');
5247
$this->user->data['user_id'] = 2;
5348
$this->user->data['is_registered'] = true;
@@ -117,7 +112,7 @@ public function add_googleanalytics_configs_data()
117112
array( // expected config and mode
118113
'settings',
119114
array('vars' => array('warnings_expire_days' => array())),
120-
array('warnings_expire_days', 'legend_googleanalytics', 'googleanalytics_id', 'googleanalytics_track_user_id'),
115+
array('warnings_expire_days', 'legend_googleanalytics', 'googleanalytics_id'),
121116
),
122117
array( // unexpected mode
123118
'foobar',

0 commit comments

Comments
 (0)