Merge pull request #86 from iMattPro/tests

iMattPro · web-flow · commit 7de187187308 · 2020-12-26T11:00:46.000-08:00
Update tests
diff --git a/tests/event/listener_test.php b/tests/event/listener_test.php
@@ -29,7 +29,7 @@ class listener_test extends \phpbb_test_case
 	/**
 	* Setup test environment
 	*/
-	public function setUp()
+	protected function setUp(): void
 	{
 		parent::setUp();
 
diff --git a/tests/functional/google_analytics_test.php b/tests/functional/google_analytics_test.php
@@ -82,6 +82,6 @@ public function test_set_acp_settings()
 	public function test_google_analytics_code()
 	{
 		$crawler = self::request('GET', 'index.php');
-		$this->assertContains($this->sample_ga_code, $crawler->filter('head > script')->eq(1)->text());
+		self::assertStringContainsString($this->sample_ga_code, $crawler->filter('head > script')->eq(1)->text());
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class listener_test extends \phpbb_test_case`
`29`	`29`	`/**`
`30`	`30`	`* Setup test environment`
`31`	`31`	`*/`
`32`		`- public function setUp()`
	`32`	`+ protected function setUp(): void`
`33`	`33`	`{`
`34`	`34`	`parent::setUp();`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,6 @@ public function test_set_acp_settings()`
`82`	`82`	`public function test_google_analytics_code()`
`83`	`83`	`{`
`84`	`84`	`$crawler = self::request('GET', 'index.php');`
`85`		`- $this->assertContains($this->sample_ga_code, $crawler->filter('head > script')->eq(1)->text());`
	`85`	`+ self::assertStringContainsString($this->sample_ga_code, $crawler->filter('head > script')->eq(1)->text());`
`86`	`86`	`}`
`87`	`87`	`}`