Messages for php min version is essentially dead code anyway

Author: iMattPro

ext.php

@@ -71,7 +71,7 @@ protected function php_requirement($php_version = PHP_VERSION_ID)
 	{
 		if ($php_version < self::MIN_PHP_ALLOWED)
 		{
-			$this->errors[] = ['PHP_VERSION_ERROR', $this->version_parse(self::MIN_PHP_ALLOWED), $this->version_parse($php_version)];
+			$this->errors[] = ['PHP_VERSION_MIN_ERROR', '7.1.0', PHP_VERSION];
 		}
 	}
 
@@ -108,15 +108,4 @@ protected function enable_failed()
 
 		return false;
 	}
-
-	/**
-	 * Convert a version id (70100) to a semantic version (7.1.0)
-	 *
-	 * @param int $version
-	 * @return string
-	 */
-	private function version_parse($version)
-	{
-		return sprintf('%d.%d.%d', $version / 10000, ($version / 100) % 100, $version % 100);
-	}
 }

language/en/common.php

@@ -162,8 +162,8 @@
 	'SKELETON_INVALID_PHPBB_MIN_VERSION'=> 'The minimum phpBB version requirement is invalid.',
 	'SKELETON_INVALID_PHPBB_MAX_VERSION'=> 'The maximum phpBB version requirement is invalid.',
 
-	'NO_ZIPARCHIVE_ERROR'	=> 'The ZipArchive class is required, but was not found in your PHP configuration.',
-	'PHP_VERSION_ERROR'		=> 'PHP %1$s or newer is required to install this version of the Skeleton Extension. You are using PHP %2$s.',
+	'NO_ZIPARCHIVE_ERROR'		=> 'The ZipArchive class is required, but was not found in your PHP configuration.',
+	'PHP_VERSION_MIN_ERROR'		=> 'PHP %1$s or newer is required to install this version of the Skeleton Extension. You are using PHP %2$s.',
 	'PHPBB_VERSION_MIN_ERROR'	=> 'phpBB %1$s or newer is required to install this version of the Skeleton Extension. You are using phpBB %2$s.',
 	'PHPBB_VERSION_MAX_ERROR'	=> 'phpBB %1$s or above is not supported by this version of the Skeleton Extension. You are using phpBB %2$s. Please check for a newer version of this extension.'
 ]);

tests/ext_test.php

@@ -103,7 +103,7 @@ public function test_enable_failed_returns_parameterized_error()
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->setExtErrors($ext, [['PHP_VERSION_ERROR', '7.1.0', '5.5.0']]);
+		$this->setExtErrors($ext, [['PHP_VERSION_MIN_ERROR', '7.1.0', '5.5.0']]);
 
 		$languageMock = $this->createMock(language::class);
 		$languageMock->method('add_lang')->willReturn(null);
@@ -119,7 +119,7 @@ public function test_enable_failed_returns_parameterized_error()
 		$method = (new \ReflectionClass($ext))->getMethod('enable_failed');
 		$method->setAccessible(true);
 
-		$this->assertEquals(['PHP_VERSION_ERROR:7.1.0:5.5.0'], $method->invoke($ext));
+		$this->assertEquals(['PHP_VERSION_MIN_ERROR:7.1.0:5.5.0'], $method->invoke($ext));
 	}
 
 	public function test_phpbb_requirement_min_error()
@@ -140,7 +140,7 @@ public function test_php_requirement_error()
 	{
 		$this->setExtErrors($this->ext, []);
 		$this->invokeProtectedMethod($this->ext, 'php_requirement', [50500]);
-		$this->assertContains('PHP_VERSION_ERROR', $this->getExtErrorKeys($this->ext));
+		$this->assertContains('PHP_VERSION_MIN_ERROR', $this->getExtErrorKeys($this->ext));
 	}
 
 	public function test_ziparchive_exists_error()