Skip to content

Commit 79a5115

Browse files
committed
Use docker compose plugin instead of the old binary
1 parent 215f366 commit 79a5115

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/run-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ jobs:
2929
run: sed -i 's/mariadb-admin/mysqladmin/' ./docker-compose.testing-${{ matrix.configuration }}.yml
3030
- name: Build images
3131
working-directory: ./testing/
32-
run: docker-compose -f ./docker-compose/docker-compose.testing-${{ matrix.configuration }}.yml build
32+
run: docker compose -f ./docker-compose/docker-compose.testing-${{ matrix.configuration }}.yml build
3333
- name: Run ${{ matrix.configuration }} tests
3434
working-directory: ./testing/
35-
run: docker-compose -f ./docker-compose/docker-compose.testing-${{ matrix.configuration }}.yml up --build --abort-on-container-exit --exit-code-from=sut
35+
run: docker compose -f ./docker-compose/docker-compose.testing-${{ matrix.configuration }}.yml up --build --abort-on-container-exit --exit-code-from=sut
3636
env:
3737
DB: ${{ matrix.database-image }}

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,24 @@ build-fpm-alpine:
1616
docker build ${DOCKER_FLAGS} -t ${DOCKER_REPO}:testing-fpm-alpine fpm-alpine
1717

1818
run:
19-
docker-compose -f ./testing/docker-compose/docker-compose.testing-default.yml up -d
19+
docker compose -f ./testing/docker-compose/docker-compose.testing-default.yml up -d
2020

2121
testing-%:
22-
docker-compose -p "phpmyadmin_$@" -f ./testing/docker-compose/docker-compose.$@.yml up --build --abort-on-container-exit --exit-code-from=sut
23-
docker-compose -p "phpmyadmin_$@" -f ./testing/docker-compose/docker-compose.$@.yml down
22+
docker compose -p "phpmyadmin_$@" -f ./testing/docker-compose/docker-compose.$@.yml up --build --abort-on-container-exit --exit-code-from=sut
23+
docker compose -p "phpmyadmin_$@" -f ./testing/docker-compose/docker-compose.$@.yml down
2424

2525
run-tests: testing-default testing-one-host testing-one-socket-host testing-config-mount-dir testing-fs-import-export testing-different-apache-port
2626

2727
logs:
28-
docker-compose -f ./testing/docker-compose/docker-compose.testing-default.yml logs
28+
docker compose -f ./testing/docker-compose/docker-compose.testing-default.yml logs
2929

3030
clean: stop rm prune
3131

3232
stop:
33-
docker-compose -f ./testing/docker-compose/docker-compose.testing-default.yml stop
33+
docker compose -f ./testing/docker-compose/docker-compose.testing-default.yml stop
3434

3535
rm:
36-
docker-compose -f ./testing/docker-compose/docker-compose.testing-default.yml rm
36+
docker compose -f ./testing/docker-compose/docker-compose.testing-default.yml rm
3737

3838
prune:
3939
docker rm `docker ps -q -a --filter status=exited`

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ You can use arbitrary servers by adding the environment variable `PMA_ARBITRARY=
8181
docker run --name phpmyadmin -d -e PMA_ARBITRARY=1 -p 8080:80 phpmyadmin:latest
8282
```
8383

84-
## Usage with docker-compose and arbitrary server
84+
## Usage with docker compose and an arbitrary server
8585

8686
This will run phpMyAdmin with the arbitrary server option - allowing you to specify any MySQL/MariaDB
8787
server on the login page.
@@ -210,7 +210,7 @@ docker run --name phpmyadmin -d -e PMA_PASSWORD_FILE=/run/secrets/db_password.tx
210210
## Run the E2E tests for this docker image
211211

212212
You can run the E2E test suite on a local test environment.
213-
The Requirements are `make`, `docker` and `docker-compose`.
213+
The Requirements are `make`, `docker` and the `docker compose` plugin.
214214

215215
Clone this repository: `https://github.com/phpmyadmin/docker.git`
216216

0 commit comments

Comments
 (0)