Skip to content

Commit 5986de6

Browse files
committed
PythonPackageNamespaceCheck: clarify the suppression is for invalid xml
pkgcore/pkgcore#466 tracks it, but pkgcore's api isn't forcing validation on metadata.xml objects, and that's forcing this downstream consumer to encode the suppression of an violation of the XSD. Signed-off-by: Brian Harring <ferringb@gmail.com>
1 parent 7302f22 commit 5986de6

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

NEWS.rst

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,29 @@ pkgcheck 0.10.40 (unreleased)
99
**New Checks:**
1010

1111
- EclassDocMissingInternal: Enforce any eclass function prefixed with ``_`` is
12-
marked with ``@INTERNAL``, with ``_elibtoolize`` being exempted. (Arthur Zamarin)
12+
marked with ``@INTERNAL``, with ``_elibtoolize`` being exempted (Arthur Zamarin)
1313

1414
- StabilizationGroupsCheck: check for invalid and non-existant stabilization
15-
groups. (Arthur Zamarin)
15+
groups (Arthur Zamarin)
1616

1717

1818
**Packaging:**
1919

2020
- ``chardet-normalizer`` is now used instead of ``chardet`` due to upstream
21-
API breakage and AI rewrite copyright concerns. (Anna (cybertailor)
21+
API breakage and AI rewrite copyright concerns (Anna (cybertailor)
2222
Vyalkova, #775)
2323

24-
- ``pytest >= 9.0`` is now required for tests.
24+
- ``pytest >= 9.0`` is now required for tests
2525

2626
**Fixes: **
2727
2828
- EclassExportFuncsBeforeInherit: this is not non-flakey. See #702; the cause
29-
of that was quite subtle, our thanks to the author for running it down.
29+
of that was quite subtle, our thanks to the author for running it down
3030
(Thomas Bracht Laumann Jespersen, #778)
3131

32+
- PythonPackageNamespaceCheck: fix exception thrown when parsing invalid
33+
``metadata.xml`` (Florian Albrechtskirchinger, #776)
34+
3235
-----------------------------
3336
pkgcheck 0.10.39 (2026-01-03)
3437
-----------------------------

src/pkgcheck/checks/python.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1104,7 +1104,9 @@ def feed(self, pkgs):
11041104

11051105
pypi_name = pypi_remotes[0].name
11061106

1107-
# skip empty remotes
1107+
# TODO: see https://github.com/pkgcore/pkgcore/issues/466 , this
1108+
# block is suppressing what is an invalid metadata.xml. This should be
1109+
# removed once 466 is addressed.
11081110
if pypi_name is None:
11091111
return
11101112

0 commit comments

Comments
 (0)