Skip to content

Commit a621b42

Browse files
committed
Improve commit message for new package import
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
1 parent 7d5fb7f commit a621b42

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

src/pkgdev/scripts/pkgdev_commit.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,10 @@ def existing(self):
317317
def add(self):
318318
"""Generate summaries for add actions."""
319319
if len(self.existing) == len(self.changes):
320-
return 'initial import'
320+
msg = f"new package, add {', '.join(self.versions)}"
321+
if len(self.versions) == 1 or len(msg) <= 50:
322+
return msg
323+
return 'new package'
321324
elif not self.revbump:
322325
msg = f"add {', '.join(self.versions)}"
323326
if len(self.versions) == 1 or len(msg) <= 50:

tests/scripts/test_pkgdev_commit.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,12 @@ def commit():
425425

426426
# initial package import
427427
repo.create_ebuild('cat/newpkg-0')
428-
assert commit() == 'cat/newpkg: initial import'
428+
assert commit() == 'cat/newpkg: new package, add 0'
429+
430+
# initial package import, overflowed title truncated
431+
for i in range(10):
432+
repo.create_ebuild(f'cat/newpkg2-{i}.0.0')
433+
assert commit() == 'cat/newpkg2: new package'
429434

430435
# single addition
431436
repo.create_ebuild('cat/pkg-1')

0 commit comments

Comments
 (0)