Fix --version outputting to stderr

Author: mxcl

crates/cli/src/main.rs

@@ -29,7 +29,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     }
 
     if flags.version_n_continue {
-        print_version(flags.json.is_some());
+        eprintln!("{}", get_version_string(flags.json.is_some()));
     }
 
     match mode {
@@ -38,7 +38,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
             Ok(())
         }
         args::Mode::Version => {
-            print_version(flags.json.is_some());
+            println!("{}", get_version_string(flags.json.is_some()));
             Ok(())
         }
         args::Mode::Query => {
@@ -101,13 +101,13 @@ async fn setup(
     Ok((conn, did_sync, config, spinner))
 }
 
-fn print_version(json: bool) {
+fn get_version_string(json: bool) -> String {
     if !json {
-        eprintln!("pkgx {}", env!("CARGO_PKG_VERSION"));
+        format!("pkgx {}", env!("CARGO_PKG_VERSION"))
     } else {
-        eprintln!(
+        format!(
             "{{\"program\": \"pkgx\", \"version\": \"{}\"}}",
             env!("CARGO_PKG_VERSION")
-        );
+        )
     }
 }

crates/lib/src/install.rs

@@ -161,13 +161,22 @@ async fn symlink(installation: &Installation, config: &Config) -> Result<(), Box
     let minor_range = if installation.pkg.version.major > 0 {
         VersionReq::caret(&v_mm)?
     } else {
-        VersionReq::parse(&format!(">={},<{}", v_mm, format!("0.{}", installation.pkg.version.minor + 1)))?
+        VersionReq::parse(&format!(
+            ">={},<0.{}",
+            v_mm,
+            installation.pkg.version.minor + 1
+        ))?
     };
     let most_minor = versions
         .iter()
         .filter(|(version, _)| minor_range.satisfies(version))
         .next_back()
-        .ok_or_else(|| anyhow::anyhow!("Could not find most minor version for {}", installation.pkg.project))?;
+        .ok_or_else(|| {
+            anyhow::anyhow!(
+                "Could not find most minor version for {}",
+                installation.pkg.project
+            )
+        })?;
 
     if most_minor.0 != installation.pkg.version {
         return Ok(());