Skip to content

Commit 6828b8a

Browse files
Fix and suppress HTML-validate errors (#972)
* Fix unique-landmark * Remove aria-hidden * Better aria labels * Bump html-validate * Fix header * Fix or suppress unique-landmark errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent c4de2e6 commit 6828b8a

9 files changed

Lines changed: 27 additions & 24 deletions

File tree

.htmlvalidate.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
"no-dup-id": ["warn"],
88
"no-inline-style": ["warn"],
99
"prefer-native-element": ["warn"],
10+
"unique-landmark": ["off"],
11+
"hidden-focusable": ["off"],
1012
"valid-id": ["error", { "relaxed": true }],
1113
"heading-level": ["off"],
1214
"input-missing-label": ["off"],

.htmlvalidateignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/_site/19.08/
22
/_site/20.07/
3+
/_site/TSPL/
34
/_site/assets/pubs/
45
/_site/assets/talks/
56
/_site/plfa.html

package-lock.json

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"devDependencies": {
33
"browser-sync": "^3.0.2",
4-
"html-validate": "^8.8.0",
4+
"html-validate": "^8.11.1",
55
"html-minifier": "^4.0.0",
66
"sass": "^1.71.1"
77
}

web/templates/footer.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<footer class="site-footer h-card">
1+
<footer class="site-footer h-card" aria-label="Site">
22
<data class="u-url" href="/"></data>
33
<div class="wrapper">
44
<h2 class="footer-heading">$pagetitle$</h2>

web/templates/header.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
<header class="site-header">
1+
<header class="site-header" aria-label="Site">
22
<div class="wrapper">
33
<a class="site-title" href="/">$pagetitle$</a>
4-
<nav class="site-nav">
4+
<nav class="site-nav" aria-label="Site">
55
<input type="checkbox" id="nav-trigger" class="nav-trigger" />
66
<label for="nav-trigger">
77
<span class="menu-icon">
@@ -19,10 +19,10 @@
1919
<a class="page-link" href="/Citing/">Citing</a>
2020
<a class="page-link" href="https://agda-zh.github.io/PLFA-zh/">中文</a>
2121
<a class="page-link" onclick="window.darkmode.toggle()">
22-
<i id="darkmode-trigger" class="fas fa-moon" aria-hidden="true"></i>
22+
<i id="darkmode-trigger" class="fas fa-moon"></i>
2323
</a>
2424
<a class="page-link" href="/plfa.epub">
25-
<i class="fa fa-book" aria-hidden="true"></i>
25+
<i class="fa fa-book"></i>
2626
</a>
2727
</div>
2828
</nav>

web/templates/next.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<nav class="pager">
1+
<nav class="pager" aria-label="Chapter">
22
<ul class="pagination">
33
$if(prev)$
44
<li><a class="pagelink" href="$prev$">Prev</a></li>

web/templates/page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<article class="post">
22
$^$${ next() }
3-
<header class="post-header">
3+
<header class="post-header" aria-label="Chapter">
44
<h1 class="post-title" $if(anchor)$id="$anchor$"$endif$>$title$</h1>
55
</header>
66
<div class="post-content">

web/templates/post.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<article class="post h-entry" itemscope itemtype="https://schema.org/BlogPosting">
2-
<header class="post-header">
2+
<header class="post-header" aria-label="Post">
33
<h1 class="post-title p-name" itemprop="name headline">$title$</h1>
44
<p class="post-meta">
55
<time class="dt-published" datetime="$date$" itemprop="datePublished">

0 commit comments

Comments
 (0)