Repository navigation
Commit 38c33cf
authored
fix: remove dead Spec.layer_sql/stat_sql bindings (#15)
* fix: remove dead Spec.layer_sql/stat_sql bindings
These methods mirrored a vestigial Rust API. Since ggsql PR #82 (the
scale-syntax rewrite, first released in v0.1.6), Spec::new() has
populated the backing fields with `vec![None; ...]` — the methods have
always returned None in every released crate. ggsql PR #569 (the
dialect/SQL-construction centralization) removed them from the Rust API
entirely, so they no longer compile against ggsql main.
Nothing consumes them: the only usage in this repo was a smoke test
asserting the calls don't crash, and querychat (R and Python) never
calls them. Removing them restores forward-compatibility with ggsql
main at zero functional cost.
Verified by building and testing against both crates.io ggsql 0.5.2
and a local ggsql main checkout.
* docs: changelog entry for Spec.layer_sql/stat_sql removal1 parent 6d4859f commit 38c33cf
3 files changed
Lines changed: 4 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
10 | 14 | | |
11 | 15 | | |
12 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1255 | 1255 | | |
1256 | 1256 | | |
1257 | 1257 | | |
1258 | | - | |
1259 | | - | |
1260 | | - | |
1261 | | - | |
1262 | | - | |
1263 | | - | |
1264 | | - | |
1265 | | - | |
1266 | | - | |
1267 | | - | |
1268 | | - | |
1269 | | - | |
1270 | | - | |
1271 | | - | |
1272 | | - | |
1273 | | - | |
1274 | | - | |
1275 | | - | |
1276 | | - | |
1277 | | - | |
1278 | | - | |
1279 | | - | |
1280 | | - | |
1281 | | - | |
1282 | | - | |
1283 | | - | |
1284 | | - | |
1285 | | - | |
1286 | | - | |
1287 | | - | |
1288 | 1258 | | |
1289 | 1259 | | |
1290 | 1260 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
546 | | - | |
547 | | - | |
548 | 546 | | |
549 | 547 | | |
550 | 548 | | |
| |||
0 commit comments