refactor(compiler): require a reference in DirectiveMeta

Requires the `DirectiveMeta` to have a `ref` so that we can find duplicates easily.

Author: crisbeto

packages/compiler-cli/src/ngtsc/imports/src/references.ts

@@ -10,7 +10,7 @@ import {Expression} from '@angular/compiler';
 import ts from 'typescript';
 
 import {AmbientImport} from '../../reflection';
-import {identifierOfNode} from '../../util/src/typescript';
+import {getSourceFile, identifierOfNode} from '../../util/src/typescript';
 
 export interface OwningModule {
   specifier: string;
@@ -57,6 +57,8 @@ export class Reference<T extends ts.Node = ts.Node> {
 
   readonly isAmbient: boolean;
 
+  readonly key: string;
+
   constructor(
     readonly node: T,
     bestGuessOwningModule: OwningModule | AmbientImport | null = null,
@@ -70,9 +72,18 @@ export class Reference<T extends ts.Node = ts.Node> {
     }
 
     const id = identifierOfNode(node);
+    const sourceFile = getSourceFile(node);
+
     if (id !== null) {
       this.identifiers.push(id);
     }
+
+    // The source file might not be defined for synthetic nodes.
+    if (sourceFile) {
+      this.key = `${sourceFile.fileName}#${node.getStart()}`;
+    } else {
+      this.key = `${this.bestGuessOwningModule?.specifier}#${id?.text}#${id?.getStart()}#${id?.getEnd()}`;
+    }
   }
 
   /**

packages/compiler/src/render3/view/t2_api.ts

@@ -98,6 +98,14 @@ export interface DirectiveMeta {
    */
   name: string;
 
+  /** Reference to the directive declaration site. */
+  ref: {
+    /** Key that uniquely identifies the reference. */
+    key: string;
+
+    // Normally we have some more fields here depending on where the reference originated from.
+  };
+
   /** The selector for the directive or `null` if there isn't one. */
   selector: string | null;
 

packages/compiler/test/render3/view/binding_spec.ts

@@ -16,6 +16,8 @@ import {CssSelector, SelectorlessMatcher, SelectorMatcher} from '../../../src/di
 
 import {findExpression} from './util';
 
+let keyCounter = 0;
+
 function makeDirectiveMeta(config: {
   name: string;
   selector: string | null;
@@ -28,6 +30,9 @@ function makeDirectiveMeta(config: {
 }): DirectiveMeta {
   return {
     name: config.name,
+    ref: {
+      key: `${config.name}#${keyCounter++}`,
+    },
     exportAs: config.exportAs ?? null,
     inputs: ClassPropertyMapping.fromMappedObject(config.inputs || {}),
     outputs: ClassPropertyMapping.fromMappedObject(config.outputs || {}),