build: migrate router to use rules_js (angular#61542)

Use ts_project and ng_project for building router

PR Close angular#61542

Author: josephperrott

packages/router/BUILD.bazel

@@ -1,20 +1,23 @@
-load("//tools:defaults.bzl", "api_golden_test", "api_golden_test_npm_package", "generate_api_docs", "ng_module", "ng_package")
+load("//tools:defaults.bzl", "api_golden_test", "api_golden_test_npm_package", "generate_api_docs", "ng_package")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "router",
     srcs = glob(
         [
             "*.ts",
             "src/**/*.ts",
         ],
     ),
-    deps = [
+    interop_deps = [
         "//packages/common",
-        "//packages/core",
         "//packages/platform-browser",
-        "@npm//rxjs",
+    ],
+    deps = [
+        "//:node_modules/rxjs",
+        "//packages/core:core_rjs",
     ],
 )
 

packages/router/test/BUILD.bazel

@@ -1,24 +1,27 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
+load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
+load("//tools:defaults2.bzl", "ts_project")
 
-ts_library(
+ts_project(
     name = "test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
-    # Visible to //:saucelabs_unit_tests_poc target
-    visibility = ["//:__pkg__"],
-    deps = [
+    interop_deps = [
         "//packages/common",
         "//packages/common/testing",
-        "//packages/core",
-        "//packages/core/rxjs-interop",
-        "//packages/core/testing",
         "//packages/platform-browser",
         "//packages/platform-browser-dynamic",
         "//packages/platform-browser/testing",
         "//packages/private/testing",
-        "//packages/router",
-        "//packages/router/testing",
-        "@npm//rxjs",
+    ],
+    # Visible to //:saucelabs_unit_tests_poc target
+    visibility = ["//:__pkg__"],
+    deps = [
+        "//:node_modules/rxjs",
+        "//packages/core:core_rjs",
+        "//packages/core/rxjs-interop:rxjs-interop_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/router:router_rjs",
+        "//packages/router/testing:testing_rjs",
     ],
 )
 

packages/router/test/bootstrap.spec.ts

@@ -6,9 +6,14 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {DOCUMENT, PlatformLocation, ɵgetDOM as getDOM} from '@angular/common';
-import {BrowserPlatformLocation} from '@angular/common/src/location/platform_location';
-import {NullViewportScroller, ViewportScroller} from '@angular/common/src/viewport_scroller';
+import {
+  DOCUMENT,
+  PlatformLocation,
+  ɵgetDOM as getDOM,
+  BrowserPlatformLocation,
+  ɵNullViewportScroller as NullViewportScroller,
+  ViewportScroller,
+} from '@angular/common';
 import {MockPlatformLocation} from '@angular/common/testing';
 import {
   ApplicationRef,
@@ -26,7 +31,6 @@ import {isNode} from '@angular/private/testing';
 import {BrowserModule} from '@angular/platform-browser';
 import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
 import {
-  Event,
   NavigationEnd,
   provideRouter,
   Router,

packages/router/test/integration/lazy_loading.spec.ts

@@ -5,7 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.dev/license
  */
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {LocationStrategy, HashLocationStrategy, Location} from '@angular/common';
 import {
   inject,

packages/router/test/integration/route_data.spec.ts

@@ -27,7 +27,7 @@ import {
 } from '../../src';
 import {map} from 'rxjs/operators';
 import {EMPTY, Observer, Observable, of} from 'rxjs';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {
   RootCmp,
   BlankCmp,

packages/router/test/integration/route_reuse_strategy.spec.ts

@@ -20,7 +20,7 @@ import {
 } from '../../src';
 import {Subscription} from 'rxjs';
 import {filter} from 'rxjs/operators';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {
   BlankCmp,
   RootCmp,

packages/router/test/integration/router_link_active.spec.ts

@@ -9,7 +9,7 @@ import {Component, NgZone} from '@angular/core';
 import {Location} from '@angular/common';
 import {TestBed} from '@angular/core/testing';
 import {Router, provideRouter} from '../../src';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {
   RootCmp,
   BlankCmp,

packages/router/test/integration/router_links.spec.ts

@@ -8,7 +8,7 @@
 import {Component} from '@angular/core';
 import {Location} from '@angular/common';
 import {TestBed, ComponentFixture} from '@angular/core/testing';
-import {By} from '@angular/platform-browser/src/dom/debug/by';
+import {By} from '@angular/platform-browser';
 import {Router} from '../../src';
 import {expect} from '@angular/private/testing/matchers';
 import {

packages/router/testing/BUILD.bazel

@@ -1,19 +1,22 @@
-load("//tools:defaults.bzl", "generate_api_docs", "ng_module")
+load("//tools:defaults.bzl", "generate_api_docs")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:public"])
 
 exports_files(["package.json"])
 
-ng_module(
+ng_project(
     name = "testing",
     srcs = glob(["**/*.ts"]),
-    deps = [
+    interop_deps = [
         "//packages/common",
         "//packages/common/testing",
-        "//packages/core",
-        "//packages/core/testing",
-        "//packages/router",
-        "@npm//rxjs",
+    ],
+    deps = [
+        "//:node_modules/rxjs",
+        "//packages/core:core_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/router:router_rjs",
     ],
 )
 

packages/router/testing/test/BUILD.bazel

@@ -1,23 +1,26 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
+load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite")
+load("//tools:defaults2.bzl", "ts_project")
 
-ts_library(
+ts_project(
     name = "test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
-    # Visible to //:saucelabs_unit_tests_poc target
-    visibility = ["//:__pkg__"],
-    deps = [
+    interop_deps = [
         "//packages/common",
         "//packages/common/testing",
-        "//packages/core",
-        "//packages/core/testing",
         "//packages/platform-browser",
         "//packages/platform-browser-dynamic",
         "//packages/platform-browser/testing",
         "//packages/private/testing",
-        "//packages/router",
-        "//packages/router/testing",
-        "@npm//rxjs",
+    ],
+    # Visible to //:saucelabs_unit_tests_poc target
+    visibility = ["//:__pkg__"],
+    deps = [
+        "//:node_modules/rxjs",
+        "//packages/core:core_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/router:router_rjs",
+        "//packages/router/testing:testing_rjs",
     ],
 )