build: migrate platform-server to rules_js (angular#61589)

Migrate platform-server to use ts_project and ng_project.

PR Close angular#61589

Author: josephperrott

packages/core/src/core_private_export.ts

@@ -5,7 +5,6 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.dev/license
  */
-
 export {
   type NavigateEvent as ɵNavigateEvent,
   type Navigation as ɵNavigation,
@@ -60,6 +59,7 @@ export {
   DeferBlockConfig as ɵDeferBlockConfig,
   DeferBlockState as ɵDeferBlockState,
 } from './defer/interfaces';
+export {getDocument as ɵgetDocument} from './render3/interfaces/document';
 export {
   convertToBitFlags as ɵconvertToBitFlags,
   setCurrentInjector as ɵsetCurrentInjector,
@@ -85,14 +85,17 @@ export {
   withDomHydration as ɵwithDomHydration,
   withI18nSupport as ɵwithI18nSupport,
   withIncrementalHydration as ɵwithIncrementalHydration,
+  CLIENT_RENDER_MODE_FLAG as ɵCLIENT_RENDER_MODE_FLAG,
 } from './hydration/api';
 export {withEventReplay as ɵwithEventReplay} from './hydration/event_replay';
 export {JSACTION_EVENT_CONTRACT as ɵJSACTION_EVENT_CONTRACT} from './event_delegation_utils';
 export {
   IS_HYDRATION_DOM_REUSE_ENABLED as ɵIS_HYDRATION_DOM_REUSE_ENABLED,
   IS_INCREMENTAL_HYDRATION_ENABLED as ɵIS_INCREMENTAL_HYDRATION_ENABLED,
+  JSACTION_BLOCK_ELEMENT_MAP as ɵJSACTION_BLOCK_ELEMENT_MAP,
 } from './hydration/tokens';
 export {
+  HydrationStatus as ɵHydrationStatus,
   HydratedNode as ɵHydratedNode,
   HydrationInfo as ɵHydrationInfo,
   readHydrationInfo as ɵreadHydrationInfo,
@@ -152,7 +155,6 @@ export {isPromise as ɵisPromise, isSubscribable as ɵisSubscribable} from './ut
 export {performanceMarkFeature as ɵperformanceMarkFeature} from './util/performance';
 export {stringify as ɵstringify, truncateMiddle as ɵtruncateMiddle} from './util/stringify';
 export {NOT_FOUND_CHECK_ONLY_ELEMENT_INJECTOR as ɵNOT_FOUND_CHECK_ONLY_ELEMENT_INJECTOR} from './view/provider_flags';
-
 export {type InputSignalNode as ɵInputSignalNode} from './authoring/input/input_signal_node';
 export {
   startMeasuring as ɵstartMeasuring,
@@ -161,10 +163,11 @@ export {
   enableProfiling as ɵenableProfiling,
   disableProfiling as ɵdisableProfiling,
 } from './profiler';
-
 export {
   ResourceImpl as ɵResourceImpl,
   encapsulateResourceError as ɵencapsulateResourceError,
 } from './resource/resource';
-
 export {getClosestComponentName as ɵgetClosestComponentName} from './internal/get_closest_component_name';
+export {getComponentDef as ɵgetComponentDef} from './render3/def_getters';
+export {DEHYDRATED_BLOCK_REGISTRY as ɵDEHYDRATED_BLOCK_REGISTRY} from './defer/registry';
+export {TimerScheduler as ɵTimerScheduler} from './defer/timer_scheduler';

packages/core/src/defer/registry.ts

@@ -15,6 +15,7 @@ import {
 } from '../event_delegation_utils';
 import {JSACTION_BLOCK_ELEMENT_MAP} from '../hydration/tokens';
 import {DehydratedDeferBlock} from './interfaces';
+import type {PromiseWithResolvers} from '../util/promise_with_resolvers';
 
 /**
  * An internal injection token to reference `DehydratedBlockRegistry` implementation

packages/core/src/defer/triggering.ts

@@ -70,7 +70,7 @@ import {
   getTDeferBlockDetails,
 } from './utils';
 import {ApplicationRef} from '../application/application_ref';
-import {DEHYDRATED_VIEWS} from '../render3/interfaces/container';
+import type {PromiseConstructor} from '../util/promise_with_resolvers';
 
 /**
  * Schedules triggering of a defer block for `on idle` and `on timer` conditions.
@@ -549,7 +549,7 @@ function cleanupRemainingHydrationQueue(
  */
 function populateHydratingStateForQueue(registry: DehydratedBlockRegistry, queue: string[]) {
   for (let blockId of queue) {
-    registry.hydrating.set(blockId, Promise.withResolvers());
+    registry.hydrating.set(blockId, (Promise as unknown as PromiseConstructor).withResolvers());
   }
 }
 

packages/core/src/util/promise_with_resolvers.ts

@@ -10,13 +10,13 @@
  * TODO(incremental-hydration): Remove this file entirely once PromiseWithResolvers lands in stable
  * node / TS.
  */
-interface PromiseWithResolvers<T> {
+export interface PromiseWithResolvers<T> {
   promise: Promise<T>;
   resolve: (value: T | PromiseLike<T>) => void;
   reject: (reason?: any) => void;
 }
 
-interface PromiseConstructor {
+export interface PromiseConstructor {
   /**
    * Creates a new Promise and returns it in an object, along with its resolve and reject functions.
    * @returns An object with the properties `promise`, `resolve`, and `reject`.

packages/core/test/resource/resource_spec.ts

@@ -19,8 +19,7 @@ import {
 } from '../../src/core';
 import {TestBed} from '../../testing';
 
-// Needed for the `Promise.withResolvers()` usage below.
-import '../../src/util/promise_with_resolvers';
+import type {PromiseConstructor} from '../../src/util/promise_with_resolvers';
 
 abstract class MockBackend<T, R> {
   protected pending = new Map<
@@ -300,7 +299,7 @@ describe('resource', () => {
     const res = resource({
       params: request,
       loader: async ({params}) => {
-        const p = Promise.withResolvers<number>();
+        const p = (Promise as unknown as PromiseConstructor).withResolvers<number>();
         resolve.push(() => p.resolve(params));
         return p.promise;
       },

packages/platform-server/BUILD.bazel

@@ -1,29 +1,31 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
-load("//tools:defaults.bzl", "api_golden_test_npm_package", "esbuild", "generate_api_docs", "ng_module", "ng_package", "tsec_test")
+load("//tools:defaults.bzl", "api_golden_test_npm_package", "esbuild", "generate_api_docs", "ng_package", "tsec_test")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "platform-server",
-    package_name = "@angular/platform-server",
     srcs = glob(
         [
             "*.ts",
             "src/**/*.ts",
         ],
         exclude = ["src/bundled-domino.d.ts"],
     ),
-    deps = [
-        ":bundled_domino_lib",
+    interop_deps = [
         "//packages/common",
         "//packages/common/http",
         "//packages/compiler",
-        "//packages/core",
         "//packages/platform-browser",
         "//packages/zone.js/lib:zone_d_ts",
-        "@npm//@types/node",
-        "@npm//rxjs",
-        "@npm//xhr2",
+        ":bundled_domino_lib",
+    ],
+    deps = [
+        "//:node_modules/@types/node",
+        "//:node_modules/rxjs",
+        "//:node_modules/xhr2",
+        "//packages/core:core_rjs",
     ],
 )
 

packages/platform-server/init/BUILD.bazel

@@ -1,9 +1,10 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
-load("//tools:defaults.bzl", "esbuild", "ng_module", "tsec_test")
+load("//tools:defaults.bzl", "esbuild", "tsec_test")
+load("//tools:defaults2.bzl", "ng_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ng_module(
+ng_project(
     name = "init",
     srcs = glob(
         [
@@ -12,7 +13,7 @@ ng_module(
         ],
         exclude = ["src/bundled-domino.d.ts"],
     ),
-    deps = [
+    interop_deps = [
         ":bundled_domino_lib",
     ],
 )

packages/platform-server/init/test/BUILD.bazel

@@ -1,13 +1,16 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
+load("//tools:defaults.bzl", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ts_project")
 
-ts_library(
+ts_project(
     name = "test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
-    deps = [
-        "//packages/platform-server/init",
+    interop_deps = [
         "//packages/platform-server/init:bundled_domino_lib",
     ],
+    deps = [
+        "//packages/platform-server/init:init_rjs",
+    ],
 )
 
 jasmine_node_test(

packages/platform-server/test/BUILD.bazel

@@ -1,21 +1,25 @@
-load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
+load("//tools:defaults.bzl", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ts_project")
 
-ts_library(
+ts_project(
     name = "dom_utils",
+    testonly = True,
     srcs = [
         "dom_utils.ts",
         "hydration_utils.ts",
     ],
-    deps = [
+    interop_deps = [
         "//packages/common",
-        "//packages/core",
-        "//packages/core/testing",
         "//packages/platform-browser",
-        "//packages/platform-server",
+    ],
+    deps = [
+        "//packages/core:core_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/platform-server:platform-server_rjs",
     ],
 )
 
-ts_library(
+ts_project(
     name = "test_lib",
     testonly = True,
     srcs = glob(
@@ -26,42 +30,46 @@ ts_library(
             "dom_utils.ts",
         ],
     ),
-    deps = [
-        ":dom_utils",
+    interop_deps = [
         "//packages:types",
-        "//packages/animations",
         "//packages/common",
         "//packages/common/http",
         "//packages/common/http/testing",
         "//packages/common/testing",
         "//packages/compiler",
-        "//packages/core",
-        "//packages/core/testing",
         "//packages/localize",
         "//packages/localize/init",
         "//packages/platform-browser",
         "//packages/platform-browser/animations",
-        "//packages/platform-server",
         "//packages/private/testing",
         "//packages/router",
-        "@npm//rxjs",
+    ],
+    deps = [
+        ":dom_utils_rjs",
+        "//:node_modules/rxjs",
+        "//packages/animations:animations_rjs",
+        "//packages/core:core_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/platform-server:platform-server_rjs",
     ],
 )
 
-ts_library(
+ts_project(
     name = "event_replay_test_lib",
     testonly = True,
     srcs = ["event_replay_spec.ts"],
-    deps = [
-        ":dom_utils",
+    interop_deps = [
         "//packages/common",
-        "//packages/core",
-        "//packages/core/primitives/event-dispatch",
-        "//packages/core/testing",
         "//packages/platform-browser",
-        "//packages/platform-server",
         "//packages/private/testing",
     ],
+    deps = [
+        ":dom_utils_rjs",
+        "//packages/core:core_rjs",
+        "//packages/core/primitives/event-dispatch:event-dispatch_rjs",
+        "//packages/core/testing:testing_rjs",
+        "//packages/platform-server:platform-server_rjs",
+    ],
 )
 
 jasmine_node_test(

packages/platform-server/test/dom_utils.ts

@@ -7,9 +7,15 @@
  */
 
 import {DOCUMENT} from '@angular/common';
-import {ApplicationRef, PLATFORM_ID, Provider, Type, ɵsetDocument} from '@angular/core';
-import {CLIENT_RENDER_MODE_FLAG} from '@angular/core/src/hydration/api';
-import {getComponentDef} from '@angular/core/src/render3/def_getters';
+import {
+  ApplicationRef,
+  PLATFORM_ID,
+  Provider,
+  Type,
+  ɵsetDocument,
+  ɵCLIENT_RENDER_MODE_FLAG as CLIENT_RENDER_MODE_FLAG,
+  ɵgetComponentDef as getComponentDef,
+} from '@angular/core';
 import {
   bootstrapApplication,
   HydrationFeature,