Skip to content

Commit fb347af

Browse files
committed
refactor: fix types extraction for private (angular#67898)
fixes types extraction for private entrypoint of language service PR Close angular#67898
1 parent d268df6 commit fb347af

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

packages/language-service/BUILD.bazel

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@aspect_rules_esbuild//esbuild:defs.bzl", "esbuild")
2-
load("//tools:defaults.bzl", "npm_package", "ts_config", "ts_project")
2+
load("//tools:defaults.bzl", "extract_types", "npm_package", "ts_config", "ts_project")
33

44
package(default_visibility = ["//visibility:public"])
55

@@ -70,6 +70,11 @@ esbuild(
7070
deps = [":private"],
7171
)
7272

73+
extract_types(
74+
name = "private_type_definitions",
75+
deps = [":private"],
76+
)
77+
7378
npm_package(
7479
srcs = [
7580
"index.d.ts",
@@ -80,7 +85,7 @@ npm_package(
8085
":factory_bundle",
8186
":factory_lib_types",
8287
":private_bundle",
83-
":private_types",
88+
":private_type_definitions",
8489
"//packages/language-service/bundles:language-service.js",
8590
],
8691
package = "@angular/language-service",

vscode-ng-language-service/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ npm_package(
6565
"**/*.map",
6666
"node_modules/@angular/language-service/private_bundle.js",
6767
"node_modules/@angular/language-service/private.d.ts",
68+
"node_modules/@angular/language-service/src/**/*.d.ts",
6869
],
6970
include_srcs_packages = [
7071
"**",

0 commit comments

Comments
 (0)