Fix magic methods detection (#2228)

* Fix magic methods detection

* Fix logic

Author: fisker

src/printer.js

@@ -2885,7 +2885,7 @@ function printNode(path, options, print) {
     case "error":
     default:
       // istanbul ignore next
-      return `Have not implemented kind ${node.kind} yet.`;
+      throw new Error(`Have not implemented kind '${node.kind}' yet.`);
   }
 }
 

src/util.js

@@ -666,17 +666,15 @@ const magicMethods = [
   "__clone",
   "__debugInfo",
 ];
-const MagicMethodsMap = magicMethods.reduce((map, obj) => {
-  map[obj.toLowerCase()] = obj;
-
-  return map;
-}, {});
+const magicMethodsMap = new Map(
+  magicMethods.map((name) => [name.toLowerCase(), name])
+);
 
 function normalizeMagicMethodName(name) {
   const loweredName = name.toLowerCase();
 
-  if (MagicMethodsMap[loweredName]) {
-    return MagicMethodsMap[loweredName];
+  if (magicMethodsMap.has(loweredName)) {
+    return magicMethodsMap.get(loweredName);
   }
 
   return name;

tests/case/__snapshots__/jsfmt.spec.js.snap

@@ -569,6 +569,10 @@ class Connection
     public function __DEBUGINFO()
     {
     }
+
+    // Not magic methods, JS Object prototype properties
+    public function __pRoTo__() {}
+    public function cOnStRuCtOr() {}
 }
 
 =====================================output=====================================
@@ -638,6 +642,14 @@ class Connection
     public function __debugInfo()
     {
     }
+
+    // Not magic methods, JS Object prototype properties
+    public function __pRoTo__()
+    {
+    }
+    public function cOnStRuCtOr()
+    {
+    }
 }
 
 ================================================================================

tests/case/magic-methods.php

@@ -64,4 +64,8 @@ public function __CLONE()
     public function __DEBUGINFO()
     {
     }
+
+    // Not magic methods, JS Object prototype properties
+    public function __pRoTo__() {}
+    public function cOnStRuCtOr() {}
 }