[aw] Primer API Review reported incomplete result

[github-actions]

Workflow Failure

Workflow: Primer API Review
Branch: main
Run: https://github.com/primer/react/actions/runs/34103705377

Warning

Task Could Not Be Completed: The agent reported that the task could not be performed due to an infrastructure or tool failure.

Reasons:

• Cannot update the existing "Primer API Review" issue (Primer API Review #8384) because the workflow's update_issue tool is configured with target: triggering, which requires the workflow to have been triggered by an issue event. This run is a scheduled run with no triggering issue, so update_issue rejects any issue_number and there is no configured path to target: '*'. Creating a new issue would violate the "one issue titled exactly 'Primer API Review'" constraint and duplicate Primer API Review #8384.

  Completed the full review work: cross-checked packages/react/src/index.ts public exports against /tmp/gh-aw/data/components.json (found 4 additional exported single-file components not in the inventory: BaseStyles.tsx, SideNav.tsx, ThemeProvider.tsx, VisuallyHidden.tsx), partitioned all 82 components into 9 batches of <=10, and dispatched all 9 to the component-api-auditor sub-agent. Every batch returned an empty response even after being retried up to 3 times with explicit follow-up prompts (write_agent), so the sub-agent delegation path is currently non-functional for this task in this environment.

To avoid losing the review work, I performed a direct, evidence-based audit myself covering two style-guide principles from contributor-docs/style.md ("Prefer authoring callback prop types with arguments that can be extended" and "Merge shared props intentionally" / className ordering), confirmed there is no rationale for any prior finding in issue #8384 (0 comments on that issue), and produced a complete replacement issue body with the following findings, all with file/line evidence:

Callback-argument extensibility violations:

• Pagination.onPageChange (Pagination.tsx:114)
• DataTable.onToggleSort (DataTable.tsx:75)
• PageLayout/DragHandle.onDrag (DragHandle.tsx:16)
• CheckboxGroup.onChange (CheckboxGroup.tsx:19)
• RadioGroup.onChange (RadioGroup.tsx:15)
• AnchoredOverlay.onOpen (AnchoredOverlay.tsx:72)

className merge-order violations (clsx(className, classes.X) instead of clsx(classes.X, className)):

• Truncate.tsx:21, Label.tsx:33, CounterLabel.tsx:36, Popover.tsx:50/112, SkeletonText.tsx:24/51, SkeletonAvatar.tsx:30, TooltipV2/Tooltip.tsx:357, Header.tsx:16/31/50, LabelGroup.tsx:302/348

I attempted update_issue with issue_number: 8384 (both without and with the parameter) and both attempts were rejected with the same "target: triggering" schema error, confirming this is a workflow configuration limitation rather than a transient failure. No further retry would succeed. Recommend either: (1) reconfiguring the workflow's update-issue target to '*' for scheduled runs, or (2) triggering this workflow via the existing issue so target: triggering applies.

• Cannot update issue Primer API Review #8384 "Primer API Review": the update_issue safe-output handler is configured with target: triggering, which rejects updates on scheduled-event runs regardless of issue_number. Confirmed again this run with identical error. Creating a new issue is disallowed since one with the exact title already exists. Workflow YAML must set update-issue: target: '*' for this workflow to succeed, or be triggered from the existing issue.

  Completed audit of all 82 public component surfaces (78 inventoried directories + BaseStyles, SideNav, ThemeProvider, VisuallyHidden exported from packages/react/src/index.ts but missing from the inventory).

Sub-agent tooling: all 9 component-api-auditor background batches returned empty responses in this run (and in the prior run), even after explicit "must produce output" instructions and retries — 18/18 total invocations across two runs failed to return content. This is a systemic tooling issue with this agent, not something fixable by prompt changes.

Direct manual audit findings (evidence-based, verified against contributor-docs/style.md "Prefer authoring callback prop types with arguments that can be extended"):

1. Pagination.onPageChange — packages/react/src/Pagination/Pagination.tsx:114 — two positional args (e, n) instead of one extensible object.
2. DataTable.onToggleSort — packages/react/src/DataTable/DataTable.tsx:75 — two positional args (columnId, direction).
3. PageLayout/DragHandle.onDrag — packages/react/src/PageLayout/DragHandle.tsx:16 — two positional args (value, isKeyboard), publicly exported via DragHandleProps.
4. CheckboxGroup.onChange — packages/react/src/CheckboxGroup/CheckboxGroup.tsx:19 — two positional args (selected, e).
5. RadioGroup.onChange — packages/react/src/RadioGroup/RadioGroup.tsx:15 — two positional args (selected, e).
6. AnchoredOverlay.onOpen — packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx:72 — two positional args (gesture, event).

Issue #8384 has zero comments, so none of these findings have documented rationale and all should remain open.

Correction from the prior review cycle: a previously reported "className merge order" finding (clsx(className, classes.X) vs clsx(classes.X, className)) was re-investigated this run and retracted — this pattern is used consistently in ~90+ locations across nearly the entire codebase and is the established convention, not a deviation. It should not appear in the issue body.

Full replacement issue body was drafted and ready to publish but could not be applied due to the target:triggering configuration blocker described above. Recommend either (a) updating the workflow's update-issue config to target: '*' so scheduled runs can update issue #8384 by number, or (b) triggering this workflow from within issue #8384 itself.

This is a structured incompletion signal (report_incomplete), not a real task outcome. Any other safe outputs emitted alongside this signal (e.g., comments) describe the failure state, not a completed review or action.

Action Required

Assign this issue to an agent to debug and fix the issue.

Debug with any coding agent

Use this prompt with any coding agent (GitHub Copilot, Claude, Gemini, etc.):

Debug the agentic workflow failure using https://raw.githubusercontent.com/github/gh-aw/main/debug.md

The failed workflow run is at https://github.com/primer/react/actions/runs/34103705377

Manually invoke the agent

Debug this workflow failure using your favorite Agent CLI and the agentic-workflows prompt.

• Start your agent
• Load the agentic-workflows skill from .github/skills/agentic-workflows/SKILL.md or https://github.com/github/gh-aw/blob/main/.github/skills/agentic-workflows/SKILL.md
• Type debug the agentic workflow primer-api-review failure in https://github.com/primer/react/actions/runs/34103705377

Tip

Stop reporting this workflow as a failure

To stop a workflow from creating failure issues, set report-failure-as-issue: false in its frontmatter:

safe-outputs:
  report-failure-as-issue: false

Generated from Primer API Review · copilot · 207.3 AIC · ◷

• expires on Sep 14, 2026, 9:18 AM UTC