[p5.js 2.0+ Bug Report]: createRadio().remove() does not remove the radio element

[slash-init]

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• WebGPU
• p5.strands
• Build process
• Unit testing
• Internationalization
• Friendly errors
• Other (specify if possible)

p5.js version

2.3.1

Web browser and version

firefox 155.0

Operating system

linux fedora

Steps to reproduce this

Steps:

1. Create a radio using createRadio().
2. Add a couple of options.
3. Call radio.remove().

Snippet:

let radio;

function setup() {
  createCanvas(400, 400);

  radio = createRadio();
  radio.option('Option 1');
  radio.option('Option 2');
  radio.position(20, 20);
}

function mousePressed() {
  radio.remove();
}

Expected behavior:

Calling radio.remove() should remove the radio element from the page, like remove() does for other p5.Elements.

Actual behavior:

The radio stays on the page and isn't removed.
I noticed that createRadio() has its own remove(value) method for removing individual options. This seems to shadow the remove() inherited from p5.Element.
So radio.remove('Option 1') works as expected, but calling radio.remove() without an argument doesn't remove the radio element.
The same thing also seems to happen with removeElements(), where the radio element is left behind.

[slash-init]

hi! @ksen0
I think I've a fix ready for this issue.
Could I be assigned to it so I can open a PR?

[ksen0]

Since the reference states Element.remove() "removes the element, stops all audio/video streams, and removes all callback functions" I agree the expectation should be that it removes the whole element. However, there has not been a bug report; a fix for this would fix a historical no-op. Assuming it's not used (as it does not behave as described) it should not be a breaking change, but I'd prefer if at least one other maintainer of the library sense-checked this @limzykenneth @davepagurek @perminder-17 before it is greenlit

[limzykenneth]

I think this is fine to fix with radio.remove() removing the associated radio elements. Since radio element is a child element of p5.Element it should be expected that the documentation description for p5.Element.remove() applies to radio.remove() unless otherwise stated.

[slash-init]

thanks @limzykenneth @ksen0 for taking a look and for the feedback.
i've opened the PR implementing the fix: #9154
have a look when you geth the chance.