Skip to content

Commit 2b06b20

Browse files
authored
chore: Add java 8 to test matrix (#2034)
migrating to flint allows us to get around some limitations we had due to the dependency on spotless, so now we can run our java compatibility integration tests on java 8 🎉 Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
1 parent 51b1cf6 commit 2b06b20

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/java-version-matrix-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
strategy:
2424
fail-fast: false
2525
matrix:
26-
java-version: [11, 17, 21, 25]
26+
java-version: [8, 11, 17, 21, 25]
2727
steps:
2828
- name: Check out
2929
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -56,8 +56,8 @@ jobs:
5656
- name: Rebuild sample apps targeting Java ${{ matrix.java-version }}
5757
run: |
5858
cd integration-tests
59-
# Note: Jetty 12 and Tomcat 11 require Java 17+, so servlet samples are skipped for Java 11
60-
if [ "${{ matrix.java-version }}" = "11" ]; then
59+
# Note: Jetty 12 and Tomcat 11 require Java 17+, so servlet samples are skipped for Java 8 & 11
60+
if [[ "${{ matrix.java-version }}" == "11" || "${{ matrix.java-version }}" == "8" ]]; then
6161
MODULES="it-common,it-exporter/it-exporter-httpserver-sample,it-exporter/it-exporter-no-protobuf,it-pushgateway"
6262
else
6363
MODULES="it-common,it-exporter/it-exporter-httpserver-sample,it-exporter/it-exporter-servlet-tomcat-sample,it-exporter/it-exporter-servlet-jetty-sample,it-exporter/it-exporter-no-protobuf,it-pushgateway"
@@ -73,7 +73,7 @@ jobs:
7373
run: |
7474
cd integration-tests
7575
# Note: Servlet tests require Java 17+ (due to Jetty 12 and Tomcat 11)
76-
if [ "${{ matrix.java-version }}" = "11" ]; then
76+
if [[ "${{ matrix.java-version }}" == "11" || "${{ matrix.java-version }}" == "8" ]]; then
7777
TEST_MODULES="it-exporter/it-no-protobuf-test,it-pushgateway"
7878
else
7979
TEST_MODULES="it-exporter/it-exporter-test,it-exporter/it-no-protobuf-test,it-pushgateway"

0 commit comments

Comments
 (0)