Skip to content

Commit a4f08b9

Browse files
Protobuf Teamcopybara-github
Protobuf Team
authored and
copybara-github
committed
Project import generated by Copybara
PiperOrigin-RevId: 417821950
1 parent 7e84b8d commit a4f08b9

4 files changed

Lines changed: 24 additions & 28 deletions

File tree

‎experimental/benchmarks/code_size/apps_jspb/all_types_proto2.js‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ function accessAllTypes() {
119119
arrayVal[0] = true;
120120
msgAllTypes.setRepeatedBoolList(arrayVal);
121121
msgAllTypes.setRepeatedBytesList(['']);
122-
arrayVal = msgAllTypes.getRepeatedBytesList();
122+
arrayVal = msgAllTypes.getRepeatedBytesList_asB64();
123123
arrayVal[0] = '';
124124
msgAllTypes.setRepeatedBytesList(arrayVal);
125125
msgPackedTypes.setPackedDoubleList([1.0]);
@@ -233,8 +233,7 @@ function accessAllTypes() {
233233

234234
let s = '';
235235
s += msgAllTypes.getOptionalBool() || false;
236-
s += msgAllTypes.getOptionalBytes() || '';
237-
// s += msgAllTypes.getOptionalBytes_asB64() || "";
236+
s += msgAllTypes.getOptionalBytes_asB64() || '';
238237
// s += msgAllTypes.getOptionalBytes_asU8() || new Uint8Array([]);
239238
s += msgAllTypes.getOptionalDouble() || 0.0;
240239
s += msgAllTypes.getOptionalFixed32() || 0;
@@ -254,10 +253,9 @@ function accessAllTypes() {
254253
s += msgAllTypes.getRepeatedBoolList();
255254
s += msgAllTypes.getRepeatedBoolList()[0];
256255
s += msgAllTypes.getRepeatedBoolList().length;
257-
s += msgAllTypes.getRepeatedBytesList();
258-
s += msgAllTypes.getRepeatedBytesList()[0];
259-
s += msgAllTypes.getRepeatedBytesList().length;
260256
s += msgAllTypes.getRepeatedBytesList_asB64();
257+
s += msgAllTypes.getRepeatedBytesList_asB64()[0];
258+
s += msgAllTypes.getRepeatedBytesList_asB64().length;
261259
s += msgAllTypes.getRepeatedBytesList_asU8();
262260
s += msgAllTypes.getRepeatedDoubleList();
263261
s += msgAllTypes.getRepeatedDoubleList()[0];

‎experimental/benchmarks/code_size/apps_jspb/all_types_proto3.js‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ function accessAllTypes() {
119119
arrayVal[0] = true;
120120
msgAllTypes.setRepeatedBoolList(arrayVal);
121121
msgAllTypes.setRepeatedBytesList(['']);
122-
arrayVal = msgAllTypes.getRepeatedBytesList();
122+
arrayVal = msgAllTypes.getRepeatedBytesList_asB64();
123123
arrayVal[0] = '';
124124
msgAllTypes.setRepeatedBytesList(arrayVal);
125125
msgPackedTypes.setPackedDoubleList([1.0]);
@@ -233,8 +233,7 @@ function accessAllTypes() {
233233

234234
let s = '';
235235
s += msgAllTypes.getOptionalBool() || false;
236-
s += msgAllTypes.getOptionalBytes() || '';
237-
// s += msgAllTypes.getOptionalBytes_asB64() || "";
236+
s += msgAllTypes.getOptionalBytes_asB64() || '';
238237
// s += msgAllTypes.getOptionalBytes_asU8() || new Uint8Array([]);
239238
s += msgAllTypes.getOptionalDouble() || 0.0;
240239
s += msgAllTypes.getOptionalFixed32() || 0;
@@ -254,10 +253,9 @@ function accessAllTypes() {
254253
s += msgAllTypes.getRepeatedBoolList();
255254
s += msgAllTypes.getRepeatedBoolList()[0];
256255
s += msgAllTypes.getRepeatedBoolList().length;
257-
s += msgAllTypes.getRepeatedBytesList();
258-
s += msgAllTypes.getRepeatedBytesList()[0];
259-
s += msgAllTypes.getRepeatedBytesList().length;
260256
s += msgAllTypes.getRepeatedBytesList_asB64();
257+
s += msgAllTypes.getRepeatedBytesList_asB64()[0];
258+
s += msgAllTypes.getRepeatedBytesList_asB64().length;
261259
s += msgAllTypes.getRepeatedBytesList_asU8();
262260
s += msgAllTypes.getRepeatedDoubleList();
263261
s += msgAllTypes.getRepeatedDoubleList()[0];

‎experimental/runtime/kernel/kernel_test.js‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ describe('Bytes access', () => {
699699
expect(accessor.getBytesWithDefault(1)).toEqual(simpleByteString);
700700
});
701701

702-
it('decodes value from wire with multiple values being present', () => {
702+
it('decodes value from wire with multple values being present', () => {
703703
const accessor = Kernel.fromArrayBuffer(
704704
createArrayBuffer(0x0A, 0x01, 0x00, 0x0A, 0x01, 0x01));
705705
expect(accessor.getBytesWithDefault(1)).toEqual(simpleByteString);
@@ -801,7 +801,7 @@ describe('Fixed32 access', () => {
801801
expect(accessor.getFixed32WithDefault(1)).toEqual(1);
802802
});
803803

804-
it('decodes value from wire with multiple values being present', () => {
804+
it('decodes value from wire with multple values being present', () => {
805805
const accessor = Kernel.fromArrayBuffer(createArrayBuffer(
806806
0x0D, 0x01, 0x00, 0x80, 0x00, 0x0D, 0x02, 0x00, 0x00, 0x00));
807807
expect(accessor.getFixed32WithDefault(1)).toEqual(2);
@@ -909,7 +909,7 @@ describe('Fixed64 access', () => {
909909
expect(accessor.getFixed64WithDefault(1)).toEqual(Int64.fromInt(1));
910910
});
911911

912-
it('decodes value from wire with multiple values being present', () => {
912+
it('decodes value from wire with multple values being present', () => {
913913
const accessor = Kernel.fromArrayBuffer(createArrayBuffer(
914914
0x09, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x02, 0x00,
915915
0x00, 0x00, 0x00, 0x00, 0x00, 0x00));
@@ -1008,7 +1008,7 @@ describe('Float access', () => {
10081008
expect(accessor.getFloatWithDefault(1)).toEqual(1);
10091009
});
10101010

1011-
it('decodes value from wire with multiple values being present', () => {
1011+
it('decodes value from wire with multple values being present', () => {
10121012
const accessor = Kernel.fromArrayBuffer(createArrayBuffer(
10131013
0x0D, 0x00, 0x00, 0x80, 0x3F, 0x0D, 0x00, 0x00, 0x80, 0xBF));
10141014
expect(accessor.getFloatWithDefault(1)).toEqual(-1);
@@ -1110,7 +1110,7 @@ describe('Int32 access', () => {
11101110
expect(accessor.getInt32WithDefault(1)).toEqual(1);
11111111
});
11121112

1113-
it('decodes value from wire with multiple values being present', () => {
1113+
it('decodes value from wire with multple values being present', () => {
11141114
const accessor =
11151115
Kernel.fromArrayBuffer(createArrayBuffer(0x08, 0x01, 0x08, 0x02));
11161116
expect(accessor.getInt32WithDefault(1)).toEqual(2);
@@ -1207,7 +1207,7 @@ describe('Int64 access', () => {
12071207
expect(accessor.getInt64WithDefault(1)).toEqual(Int64.fromInt(1));
12081208
});
12091209

1210-
it('decodes value from wire with multiple values being present', () => {
1210+
it('decodes value from wire with multple values being present', () => {
12111211
const accessor =
12121212
Kernel.fromArrayBuffer(createArrayBuffer(0x08, 0x01, 0x08, 0x02));
12131213
expect(accessor.getInt64WithDefault(1)).toEqual(Int64.fromInt(2));
@@ -1306,7 +1306,7 @@ describe('Sfixed32 access', () => {
13061306
expect(accessor.getSfixed32WithDefault(1)).toEqual(1);
13071307
});
13081308

1309-
it('decodes value from wire with multiple values being present', () => {
1309+
it('decodes value from wire with multple values being present', () => {
13101310
const accessor = Kernel.fromArrayBuffer(createArrayBuffer(
13111311
0x0D, 0x01, 0x00, 0x80, 0x00, 0x0D, 0x02, 0x00, 0x00, 0x00));
13121312
expect(accessor.getSfixed32WithDefault(1)).toEqual(2);
@@ -1404,7 +1404,7 @@ describe('Sfixed64 access', () => {
14041404
expect(accessor.getSfixed64WithDefault(1)).toEqual(Int64.fromInt(1));
14051405
});
14061406

1407-
it('decodes value from wire with multiple values being present', () => {
1407+
it('decodes value from wire with multple values being present', () => {
14081408
const accessor = Kernel.fromArrayBuffer(createArrayBuffer(
14091409
0x09, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x02, 0x00,
14101410
0x00, 0x00, 0x00, 0x00, 0x00, 0x00));
@@ -1502,7 +1502,7 @@ describe('Sint32 access', () => {
15021502
expect(accessor.getSint32WithDefault(1)).toEqual(1);
15031503
});
15041504

1505-
it('decodes value from wire with multiple values being present', () => {
1505+
it('decodes value from wire with multple values being present', () => {
15061506
const accessor =
15071507
Kernel.fromArrayBuffer(createArrayBuffer(0x08, 0x03, 0x08, 0x02));
15081508
expect(accessor.getSint32WithDefault(1)).toEqual(1);
@@ -1599,7 +1599,7 @@ describe('SInt64 access', () => {
15991599
expect(accessor.getSint64WithDefault(1)).toEqual(Int64.fromInt(1));
16001600
});
16011601

1602-
it('decodes value from wire with multiple values being present', () => {
1602+
it('decodes value from wire with multple values being present', () => {
16031603
const accessor =
16041604
Kernel.fromArrayBuffer(createArrayBuffer(0x08, 0x01, 0x08, 0x02));
16051605
expect(accessor.getSint64WithDefault(1)).toEqual(Int64.fromInt(1));
@@ -1698,7 +1698,7 @@ describe('String access', () => {
16981698
expect(accessor.getStringWithDefault(1)).toEqual('a');
16991699
});
17001700

1701-
it('decodes value from wire with multiple values being present', () => {
1701+
it('decodes value from wire with multple values being present', () => {
17021702
const accessor = Kernel.fromArrayBuffer(
17031703
createArrayBuffer(0x0A, 0x01, 0x60, 0x0A, 0x01, 0x61));
17041704
expect(accessor.getStringWithDefault(1)).toEqual('a');
@@ -1789,7 +1789,7 @@ describe('Uint32 access', () => {
17891789
expect(accessor.getUint32WithDefault(1)).toEqual(1);
17901790
});
17911791

1792-
it('decodes value from wire with multiple values being present', () => {
1792+
it('decodes value from wire with multple values being present', () => {
17931793
const accessor =
17941794
Kernel.fromArrayBuffer(createArrayBuffer(0x08, 0x01, 0x08, 0x02));
17951795
expect(accessor.getUint32WithDefault(1)).toEqual(2);
@@ -1896,7 +1896,7 @@ describe('Uint64 access', () => {
18961896
expect(accessor.getUint64WithDefault(1)).toEqual(Int64.fromInt(1));
18971897
});
18981898

1899-
it('decodes value from wire with multiple values being present', () => {
1899+
it('decodes value from wire with multple values being present', () => {
19001900
const accessor =
19011901
Kernel.fromArrayBuffer(createArrayBuffer(0x08, 0x01, 0x08, 0x02));
19021902
expect(accessor.getUint64WithDefault(1)).toEqual(Int64.fromInt(2));
@@ -1996,7 +1996,7 @@ describe('Double access', () => {
19961996
});
19971997

19981998

1999-
it('decodes value from wire with multiple values being present', () => {
1999+
it('decodes value from wire with multple values being present', () => {
20002000
const accessor = Kernel.fromArrayBuffer(createArrayBuffer(
20012001
0x09, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF0, 0x3F, 0x09, 0x00, 0x00,
20022002
0x00, 0x00, 0x00, 0x00, 0xF0, 0xBF));

‎experimental/runtime/kernel/tag_test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@ describe('skipField', () => {
9595

9696
it('skips group in group', () => {
9797
const buffer = createArrayBuffer(
98-
0x0B, // start outer
98+
0x0B, // start outter
9999
0x10, 0x01, // field: 2, value: 1
100100
0x0B, // start inner group
101101
0x10, 0x01, // payload inner group
102102
0x0C, // stop inner group
103-
0x0C // end outer
103+
0x0C // end outter
104104
);
105105
const bufferDecoder = BufferDecoder.fromArrayBuffer(buffer);
106106
bufferDecoder.setCursor(1);

0 commit comments

Comments
 (0)