Add reorder-python-imports and autoflake hooks

Also:

- Change the order of the hooks, so those that change code but do not
care about formatting run first, then black, and finally checkers like mypy.

- Drop 'linting' environment: not needed anymore given we are using pre-commit.ci.
- Do not run 'docs' on CI: we already use readthedocs.io for that (but keep tox environment for local execution).

Author: nicoddemus

.github/workflows/main.yml

@@ -31,9 +31,6 @@ jobs:
           "ubuntu-py311",
           "ubuntu-pypy3",
           "ubuntu-benchmark",
-
-          "linting",
-          "docs",
         ]
 
         include:
@@ -87,14 +84,6 @@ jobs:
             python: "3.8"
             os: ubuntu-latest
             tox_env: "benchmark"
-          - name: "linting"
-            python: "3.8"
-            os: ubuntu-latest
-            tox_env: "linting"
-          - name: "docs"
-            python: "3.8"
-            os: ubuntu-latest
-            tox_env: "docs"
 
     steps:
     - uses: actions/checkout@v3

.pre-commit-config.yaml

@@ -1,28 +1,43 @@
 repos:
--   repo: https://github.com/psf/black
-    rev: 22.10.0
+-   repo: https://github.com/PyCQA/autoflake
+    rev: v1.7.7
     hooks:
-    -   id: black
-        args: [--safe, --quiet]
--   repo: https://github.com/asottile/blacken-docs
-    rev: v1.12.1
+    -   id: autoflake
+        name: autoflake
+        args: ["--in-place", "--remove-unused-variables", "--remove-all-unused-imports"]
+        language: python
+        files: \.py$
+-   repo: https://github.com/asottile/reorder_python_imports
+    rev: v3.9.0
     hooks:
-    -   id: blacken-docs
-        additional_dependencies: [black==22.10.0]
+    -   id: reorder-python-imports
+        args: ['--application-directories=.:src', --py37-plus]
 -   repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v2.1.0
     hooks:
     -   id: trailing-whitespace
     -   id: end-of-file-fixer
     -   id: flake8
         additional_dependencies: [flake8-typing-imports]
--   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.990
+-   repo: https://github.com/pre-commit/pygrep-hooks
+    rev: v1.9.0
     hooks:
-    -   id: mypy
-        files: ^(src/|testing/)
-        args: []
-        additional_dependencies: [pytest]
+    -   id: rst-backticks
+-   repo: https://github.com/asottile/pyupgrade
+    rev: v3.2.2
+    hooks:
+    -   id: pyupgrade
+        args: [--py37-plus]
+-   repo: https://github.com/psf/black
+    rev: 22.10.0
+    hooks:
+    -   id: black
+        args: [--safe, --quiet]
+-   repo: https://github.com/asottile/blacken-docs
+    rev: v1.12.1
+    hooks:
+    -   id: blacken-docs
+        additional_dependencies: [black==22.10.0]
 -   repo: local
     hooks:
     -   id: rst
@@ -31,12 +46,10 @@ repos:
         files: ^(CHANGELOG.rst|HOWTORELEASE.rst|README.rst|changelog/.*)$
         language: python
         additional_dependencies: [pygments, restructuredtext_lint]
--   repo: https://github.com/pre-commit/pygrep-hooks
-    rev: v1.9.0
-    hooks:
-    -   id: rst-backticks
--   repo: https://github.com/asottile/pyupgrade
-    rev: v3.2.2
+-   repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v0.990
     hooks:
-    -   id: pyupgrade
-        args: [--py37-plus]
+    -   id: mypy
+        files: ^(src/|testing/)
+        args: []
+        additional_dependencies: [pytest]

tox.ini

@@ -20,12 +20,6 @@ deps=
   pytest
   pytest-benchmark
 
-[testenv:linting]
-skip_install = true
-basepython = python3
-deps = pre-commit
-commands = pre-commit run --all-files --show-diff-on-failure
-
 [testenv:docs]
 deps =
   sphinx