Merge pull request #1225 from mihau/fix-window-update-on-closed-streams

ignore WINDOW_UPDATE frames on removed or non-existent stream

Author: Kriechi

h2/connection.py

@@ -1733,10 +1733,13 @@ def _receive_window_update_frame(self, frame):
         )
 
         if frame.stream_id:
-            stream = self._get_stream_by_id(frame.stream_id)
-            frames, stream_events = stream.receive_window_update(
-                frame.window_increment
-            )
+            try:
+                stream = self._get_stream_by_id(frame.stream_id)
+                frames, stream_events = stream.receive_window_update(
+                    frame.window_increment
+                )
+            except StreamClosedError:
+                return [], events
         else:
             # Increment our local flow control window.
             self.outbound_flow_control_window = guard_increment_window(

test/test_closed_streams.py

@@ -178,6 +178,14 @@ def test_receive_window_update_on_closed_stream(self, frame_factory):
         events = c.receive_data(window_update_frame.serialize())
         assert not events
 
+        # Getting open_inbound_streams property will trigger stream accounting
+        # which results in removing closed streams.
+        c.open_inbound_streams
+
+        # Another window_update_frame is received for stream 1
+        events = c.receive_data(window_update_frame.serialize())
+        assert not events
+
 
 class TestStreamsClosedByEndStream(object):
     example_request_headers = [