Skip to content

Commit b2aef2b

Browse files
sci-c0TurtleNishantneersighted
authored
Poetry Install with pip unavailable shouldn't throw Exception (#4522)
When installing Poetry through `install-poetry.py`, if `pip` is not available, Exception should not be raised, rather installation should be aborted with user-friendly error msg. Fixes #4521 Co-authored-by: TurtleNishant <nishant@turtlelectric.com> Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
1 parent 396c06a commit b2aef2b

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

install-poetry.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,10 +516,11 @@ def make_env(self, version: str) -> Path:
516516
env_path = self._data_dir.joinpath("venv")
517517

518518
with temporary_directory() as tmp_dir:
519-
subprocess.call(
519+
subprocess.run(
520520
[sys.executable, "-m", "pip", "install", "virtualenv", "-t", tmp_dir],
521521
stdout=subprocess.PIPE,
522522
stderr=subprocess.STDOUT,
523+
check=True,
523524
)
524525

525526
sys.path.insert(0, tmp_dir)

0 commit comments

Comments
 (0)