Merge pull request #836 from iangelak/808-remove-build_ext_parallel

fix: Remove build_ext_parallel feature

Author: mergify[bot]

src/fromager/packagesettings.py

@@ -242,7 +242,7 @@ class BuildOptions(pydantic.BaseModel):
 
     ::
 
-        build_ext_parallel: False
+        build_ext_parallel: False  # DEPRECATED: ignored, will be removed
         cpu_cores_per_job: 1
         memory_per_job_gb: 1.0
     """
@@ -252,8 +252,10 @@ class BuildOptions(pydantic.BaseModel):
     build_ext_parallel: bool = False
     """Configure `build_ext[parallel]` in `DIST_EXTRA_CONFIG`
 
-    This enables parallel builds of setuptools extensions. Incompatible
-    with some packages, e.g. numba 0.60.0.
+    .. deprecated:: 0.72.0
+       This option is deprecated and will be removed in a future release.
+       The parallel build feature for extensions is unsafe due to race conditions.
+       This option is now ignored and will emit a warning if set to True.
     """
 
     cpu_cores_per_job: int = Field(default=1, ge=1)

src/fromager/wheels.py

@@ -7,7 +7,6 @@
 import shutil
 import sys
 import tempfile
-import textwrap
 import typing
 import zipfile
 
@@ -302,23 +301,13 @@ def build_wheel(
         build_env=build_env,
     )
 
-    if (
-        pbi.build_ext_parallel
-        and "DIST_EXTRA_CONFIG" not in extra_environ
-        and "MAX_JOBS" in extra_environ
-    ):
-        # configure setuptools to use parallel builds
-        # https://setuptools.pypa.io/en/latest/deprecated/distutils/configfile.html
-        dist_extra_cfg = build_env.path / "dist-extra.cfg"
-        dist_extra_cfg.write_text(
-            textwrap.dedent(
-                f"""
-                [build_ext]
-                parallel = {extra_environ["MAX_JOBS"]}
-                """
-            )
+    if pbi.build_ext_parallel:
+        logger.warning(
+            "%s: build_ext_parallel is deprecated and will be removed in a "
+            "future release. The parallel build feature for extensions is unsafe and "
+            "can cause build failures or miscompiled wheels. This option is now ignored.",
+            req.name,
         )
-        extra_environ["DIST_EXTRA_CONFIG"] = str(dist_extra_cfg)
 
     overrides.find_and_invoke(
         req.name,