Skip to content

cleanup(bootstrapper): clarify public/private status of _DEFAULT_BG_THREADS #1246

Description

@LalatenduMohanty

_DEFAULT_BG_THREADS is exported in src/fromager/bootstrapper/__init__.py via __all__ but uses a leading underscore, sending mixed signals about whether it's public API. It's used by src/fromager/commands/bootstrap.py as a CLI default value.

Pre-existing naming from the original monolithic bootstrapper.py, surfaced during review of #1226.

Option A: Remove from __all__ and keep the underscore. The commands/ package is internal to fromager, so accessing it as a private name is fine.

Option B: Rename to DEFAULT_BG_THREADS (drop underscore) and keep in __all__, making it an explicit public API.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions