Skip to content

Commit 459a8b8

Browse files
miss-islingtonjelle-openaiJelleZijlstra
authored
[3.14] gh-159739: Preserve the full maxlen when copying deque subclasses (GH-159765) (#159897)
(cherry picked from commit e3c3955) Co-authored-by: Jelle Zijlstra <jelle@openai.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
1 parent 3ef1c81 commit 459a8b8

3 files changed

Lines changed: 8 additions & 1 deletion

File tree

‎Lib/test/test_deque.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -810,6 +810,12 @@ def __iter__(self):
810810

811811
class TestSubclass(unittest.TestCase):
812812

813+
def test_copy_maxlen(self):
814+
original = Deque('abc', maxlen=support.MAX_Py_ssize_t)
815+
copied = original.copy()
816+
self.assertEqual(copied, original)
817+
self.assertEqual(copied.maxlen, original.maxlen)
818+
813819
def test_basics(self):
814820
d = Deque(range(25))
815821
d.__init__(range(200))
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix copying :class:`collections.deque` subclasses with a large maximum length.

‎Modules/_collectionsmodule.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ deque_copy_impl(dequeobject *deque)
645645
result = PyObject_CallOneArg((PyObject *)(Py_TYPE(deque)),
646646
(PyObject *)deque);
647647
else
648-
result = PyObject_CallFunction((PyObject *)(Py_TYPE(deque)), "Oi",
648+
result = PyObject_CallFunction((PyObject *)(Py_TYPE(deque)), "On",
649649
deque, old_deque->maxlen, NULL);
650650
if (result != NULL && !PyObject_TypeCheck(result, state->deque_type)) {
651651
PyErr_Format(PyExc_TypeError,

0 commit comments

Comments
 (0)