Skip to content

Commit ee9715a

Browse files
review: move seekable test
1 parent 25fede6 commit ee9715a

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

‎Lib/test/test_io/test_fileio.py‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ def testWeakRefs(self):
5050

5151
def testSeekTell(self):
5252
self.f.write(bytes(range(20)))
53+
# An invalid argument must not mark the file as non-seekable.
54+
self.assertRaises(OSError, self.f.seek, -1)
55+
self.assertTrue(self.f.seekable())
5356
self.assertEqual(self.f.tell(), 20)
5457
self.f.seek(0)
5558
self.assertEqual(self.f.tell(), 0)
@@ -61,9 +64,6 @@ def testSeekTell(self):
6164
self.assertEqual(self.f.tell(), 10)
6265
self.f.seek(-5, 2)
6366
self.assertEqual(self.f.tell(), 15)
64-
65-
def testSeekableAfterFailedSeek(self) -> None:
66-
self.assertRaises(OSError, self.f.seek, -1)
6767
self.assertTrue(self.f.seekable())
6868

6969
def testAttributes(self):
@@ -557,6 +557,13 @@ def testAbles(self):
557557
f.close()
558558

559559
if sys.platform != "win32":
560+
# On Windows, lseek somehow succeeds on pipes.
561+
r, w = os.pipe()
562+
os.close(w)
563+
with self.FileIO(r, "r") as f:
564+
self.assertRaises(OSError, f.seek, 0)
565+
self.assertEqual(f.seekable(), False)
566+
560567
try:
561568
f = self.FileIO("/dev/tty", "a")
562569
except OSError:

0 commit comments

Comments
 (0)