Skip to content

Commit 49f3daf

Browse files
authored
Merge pull request #541 from python/debt/simple-normalize
Revert normalize() performance changes (gh-143658)
2 parents 996a13c + 73efee2 commit 49f3daf

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

‎importlib_metadata/__init__.py‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -992,15 +992,8 @@ def __init__(self, name: str | None):
992992
def normalize(name):
993993
"""
994994
PEP 503 normalization plus dashes as underscores.
995-
996-
Specifically avoids ``re.sub`` as prescribed for performance
997-
benefits (see python/cpython#143658).
998995
"""
999-
value = name.lower().replace("-", "_").replace(".", "_")
1000-
# Condense repeats
1001-
while "__" in value:
1002-
value = value.replace("__", "_")
1003-
return value
996+
return re.sub(r"[-_.]+", "-", name).lower().replace('-', '_')
1004997

1005998
@staticmethod
1006999
def legacy_normalize(name):

0 commit comments

Comments
 (0)