Skip to content

Commit 4579636

Browse files
committed
Correctly identify cache keys from the current item
The 2to3 conversion changed the `has_key` to `in` but in this instance, the class overrides `__contains__` in a way that changes the semantics of it.
1 parent 7419397 commit 4579636

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

code/planet/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,10 @@ def cache_read_entries(self):
617617
for key in keys:
618618
if key.find(" ") != -1:
619619
continue
620-
if key in self:
620+
621+
# We can't use __contains__ / `in` syntax with the Cache type; it does something
622+
# different (using `has_item` above)
623+
if self.has_key(key):
621624
continue
622625

623626
item = NewsItem(self, key)

0 commit comments

Comments
 (0)