Fix for spaces in EDITOR env var (#102)

Author: hugovk

.github/workflows/test.yml

@@ -14,4 +14,5 @@ jobs:
           python-version: 3.x
       - run: |
           python -m pip install -r dev-requirements.txt
+      - run: |
           pytest tests/

release.py

@@ -215,8 +215,9 @@ def bump(tag):
     print('Please commit and use --tag')
 
 
-def manual_edit(fn):
-    run_cmd([os.environ["EDITOR"], fn])
+def manual_edit(fn: str) -> None:
+    editor = os.environ["EDITOR"].split()
+    run_cmd([*editor, fn])
 
 
 @contextmanager

tests/test_release.py

@@ -0,0 +1,28 @@
+import pytest
+from pytest_mock import MockerFixture
+
+import release
+
+
+@pytest.mark.parametrize(
+    ["test_editor", "expected"],
+    [
+        ("vim", ["vim", "README.rst"]),
+        ("bbedit --wait", ["bbedit", "--wait", "README.rst"]),
+    ],
+)
+def test_manual_edit(
+    mocker: MockerFixture,
+    monkeypatch: pytest.MonkeyPatch,
+    test_editor: str,
+    expected: list[str],
+) -> None:
+    # Arrange
+    monkeypatch.setenv("EDITOR", test_editor)
+    mock_run_cmd = mocker.patch("release.run_cmd")
+
+    # Act
+    release.manual_edit("README.rst")
+
+    # Assert
+    mock_run_cmd.assert_called_once_with(expected)