Repository navigation
Commit 018dadc
committed
docker - remove dependency on types-requests because requests ships types'
Requests 2.34 ships inline type information, so depend on it directly
instead of types-requests:
- types-requests -> requests>=2.34.0: Requests now ships its own type
information, so the separate stub package is redundant. As per
#15813 I've added the lower
bound.
- `Sequence[str]` -> `list[str]`: `APIClient` inherits `Session.__attrs__`,
which Requests declares as `list[str]`. An overriding mutable attribute
must keep the same type.
- `ConnectionPool` -> `HTTPConnectionPool`: Requests declares
`HTTPAdapter.get_connection_with_tls_context()` as returning
`HTTPConnectionPool`. Docker’s override cannot use the broader
`ConnectionPool` return type.
Co-Authored-By: Factory Droid (GPT-5.6 Sol)1 parent a746e49 commit 018dadc
3 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
0 commit comments