Add missing types in xml.dom.minidom (#9731)

Author: Avasam

stdlib/xml/dom/minidom.pyi

@@ -1,10 +1,14 @@
 import sys
 import xml.dom
 from _typeshed import Incomplete, ReadableBuffer, SupportsRead, SupportsWrite
+from typing import NoReturn, TypeVar
 from typing_extensions import Literal, Self
+from xml.dom.minicompat import NodeList
 from xml.dom.xmlbuilder import DocumentLS, DOMImplementationLS
 from xml.sax.xmlreader import XMLReader
 
+_N = TypeVar("_N", bound=Node)
+
 def parse(file: str | SupportsRead[ReadableBuffer | str], parser: XMLReader | None = None, bufsize: int | None = None): ...
 def parseString(string: str | ReadableBuffer, parser: XMLReader | None = None): ...
 def getDOMImplementation(features=None) -> DOMImplementation | None: ...
@@ -34,7 +38,7 @@ class Node(xml.dom.Node):
 
     def hasChildNodes(self) -> bool: ...
     def insertBefore(self, newChild, refChild): ...
-    def appendChild(self, node): ...
+    def appendChild(self, node: _N) -> _N: ...
     def replaceChild(self, newChild, oldChild): ...
     def removeChild(self, oldChild): ...
     def normalize(self) -> None: ...
@@ -143,7 +147,7 @@ class Element(Node):
     removeAttributeNodeNS: Incomplete
     def hasAttribute(self, name: str) -> bool: ...
     def hasAttributeNS(self, namespaceURI: str, localName) -> bool: ...
-    def getElementsByTagName(self, name: str): ...
+    def getElementsByTagName(self, name: str) -> NodeList[Node]: ...
     def getElementsByTagNameNS(self, namespaceURI: str, localName): ...
     def writexml(self, writer: SupportsWrite[str], indent: str = "", addindent: str = "", newl: str = "") -> None: ...
     def hasAttributes(self) -> bool: ...
@@ -158,12 +162,12 @@ class Childless:
     childNodes: Incomplete
     firstChild: Incomplete
     lastChild: Incomplete
-    def appendChild(self, node) -> None: ...
+    def appendChild(self, node) -> NoReturn: ...
     def hasChildNodes(self) -> bool: ...
-    def insertBefore(self, newChild, refChild) -> None: ...
-    def removeChild(self, oldChild) -> None: ...
+    def insertBefore(self, newChild, refChild) -> NoReturn: ...
+    def removeChild(self, oldChild) -> NoReturn: ...
     def normalize(self) -> None: ...
-    def replaceChild(self, newChild, oldChild) -> None: ...
+    def replaceChild(self, newChild, oldChild) -> NoReturn: ...
 
 class ProcessingInstruction(Childless, Node):
     nodeType: int
@@ -254,10 +258,10 @@ class Entity(Identified, Node):
     notationName: Incomplete
     childNodes: Incomplete
     def __init__(self, name, publicId, systemId, notation) -> None: ...
-    def appendChild(self, newChild) -> None: ...
-    def insertBefore(self, newChild, refChild) -> None: ...
-    def removeChild(self, oldChild) -> None: ...
-    def replaceChild(self, newChild, oldChild) -> None: ...
+    def appendChild(self, newChild) -> NoReturn: ...
+    def insertBefore(self, newChild, refChild) -> NoReturn: ...
+    def removeChild(self, oldChild) -> NoReturn: ...
+    def replaceChild(self, newChild, oldChild) -> NoReturn: ...
 
 class Notation(Identified, Childless, Node):
     nodeType: int
@@ -300,7 +304,7 @@ class Document(Node, DocumentLS):
     doctype: DocumentType | None
     childNodes: Incomplete
     def __init__(self) -> None: ...
-    def appendChild(self, node): ...
+    def appendChild(self, node: _N) -> _N: ...
     documentElement: Incomplete
     def removeChild(self, oldChild): ...
     def unlink(self) -> None: ...
@@ -315,7 +319,7 @@ class Document(Node, DocumentLS):
     def createElementNS(self, namespaceURI: str, qualifiedName: str): ...
     def createAttributeNS(self, namespaceURI: str, qualifiedName: str) -> Attr: ...
     def getElementById(self, id): ...
-    def getElementsByTagName(self, name: str): ...
+    def getElementsByTagName(self, name: str) -> NodeList[Node]: ...
     def getElementsByTagNameNS(self, namespaceURI: str, localName): ...
     def isSupported(self, feature: str, version: str | None) -> bool: ...
     def importNode(self, node, deep): ...