Fix form issues when changing member data

Author: sdelquin

apps/commons/templates/includes/error_list.html

@@ -1,6 +1,6 @@
-{% if field.errors %}
+{% if errors %}
   <ul class="errorlist">
-    {% for error in field.errors %}
+    {% for error in errors %}
     <li>{{ error }}</li>
     {% endfor %}
   </ul>

apps/commons/templatetags/utils.py

@@ -37,6 +37,7 @@ def is_active(context, named_url):
 
 @register.inclusion_tag('includes/error_list.html')
 def error_list(field):
+    print(field, type(field))
     return {
         'errors': field.errors,
     }

apps/members/forms.py

@@ -155,7 +155,6 @@ def save(self, request):
 
 
 class ChangeAddressForm(forms.ModelForm):
-
     class Meta:
         model = Member
         fields = [
@@ -167,7 +166,9 @@ class Meta:
         ]
 
     address = forms.CharField(label='Dirección', strip=True)
-    rest_address = forms.CharField(label='', strip=True)
-    postal_code = forms.CharField(label="Cód. postal", max_length=12, strip=True)
+    rest_address = forms.CharField(label='', required=False, strip=True)
+    postal_code = forms.CharField(
+        label="Cód. postal", max_length=12, strip=True
+    )
     city = forms.CharField(label='Ciudad', strip=True)
-    phone = forms.CharField(label='Teléfono', strip=True)
+    phone = forms.CharField(label='Teléfono', required=False, strip=True)

apps/members/urls.py

@@ -9,7 +9,9 @@
     path("profile/", views.profile, name="profile"),
     path("membership/", views.view_membership, name="membership"),
     path("password/change/", views.password_change, name="password_change"),
-    path("address/change/", views.ChangeAddress.as_view(), name="address_change"),
+    path(
+        "address/change/", views.ChangeAddress.as_view(), name="address_change"
+    ),
     path("login/", views.member_login, name="login"),
     path("logout/", views.member_logout, name="logout"),
 ]

apps/members/views.py

@@ -6,8 +6,8 @@
 from django.core.exceptions import PermissionDenied
 from django.http import HttpRequest, HttpResponse
 from django.shortcuts import redirect, render
-from django.views.generic import UpdateView
 from django.urls import reverse, reverse_lazy
+from django.views.generic import UpdateView
 
 from . import forms
 from .menu import main_menu
@@ -114,9 +114,16 @@ class ChangeAddress(UpdateView):
     def get_success_url(self):
         return reverse_lazy('members:profile')
 
-    def get_object(self, qyeryset=None):
+    def get_object(self, queryset=None):
         return self.request.user.member
 
+    def form_invalid(self, form):
+        num_errors = sum(len(err) for err in form.errors.values())
+        messages.error(
+            self.request, f'El formulario tiene {num_errors} errores'
+        )
+        return super().form_invalid(form)
+
     def get_context_data(self, **kwargs):
         context = {
             'menu': main_menu,

main/settings.py

@@ -172,7 +172,7 @@
 # Internationalization
 # https://docs.djangoproject.com/en/2.0/topics/i18n/
 
-LANGUAGE_CODE = 'en-us'
+LANGUAGE_CODE = 'es-ES'
 
 TIME_ZONE = config('TIME_ZONE', default='UTC')