From 1d933a91a4169ab0417c39861fcdf7a4db7f7409 Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Thu, 19 Nov 2026 15:48:00 +0000 Subject: [PATCH 1/2] workflows: Harden GitHub Actions Apply some standard GitHub Actions security measures: - Limit the GITHUB_TOKEN to read-only repository access with a top-level "permissions: contents: read", rather than relying on the repository default, which may grant write access. - Set "persist-credentials: false" on all checkouts so the token is not left in .git/config for later build steps to read. - Pin all actions to commit SHAs instead of mutable tags, guarding against a compromised tag being moved to malicious code. This is most important for the third-party webispy/checkpatch-action. At the same time, update actions/checkout to v7.0.1 and actions/upload-artifact to v7.0.2; neither has breaking changes relevant to these workflows. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Phil Elwell --- .github/workflows/checkpatch.yml | 8 ++++++-- .github/workflows/dtoverlaycheck.yml | 6 +++++- .github/workflows/kernel-build.yml | 8 ++++++-- .github/workflows/kunit.yml | 15 ++++++++++++--- 4 files changed, 29 insertions(+), 8 deletions(-) diff --git a/.github/workflows/checkpatch.yml b/.github/workflows/checkpatch.yml index c214226654dc1b..8c162747eb8fe4 100644 --- a/.github/workflows/checkpatch.yml +++ b/.github/workflows/checkpatch.yml @@ -1,6 +1,9 @@ name: Advisory checkpatch review on: [pull_request] +permissions: + contents: read + jobs: review: name: checkpatch review @@ -8,11 +11,12 @@ jobs: steps: - name: 'Calculate PR commits + 1' run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 1 ))" >> $GITHUB_ENV - - uses: actions/checkout@v4 + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: + persist-credentials: false ref: ${{ github.event.pull_request.head.sha }} fetch-depth: ${{ env.PR_FETCH_DEPTH }} - name: Copy checkpatch.conf run: cp ${{github.workspace}}/.github/workflows/ci_checkpatch.conf ${{github.workspace}}/.checkpatch.conf - name: Run checkpatch review - uses: webispy/checkpatch-action@v9 + uses: webispy/checkpatch-action@58374fe5bb03358b23d3d6871e2ff290ce77fcd2 # v9 diff --git a/.github/workflows/dtoverlaycheck.yml b/.github/workflows/dtoverlaycheck.yml index 15e8818bb57c1c..e0711e1b1d075a 100644 --- a/.github/workflows/dtoverlaycheck.yml +++ b/.github/workflows/dtoverlaycheck.yml @@ -11,6 +11,9 @@ on: branches: [ "rpi-*" ] workflow_dispatch: +permissions: + contents: read + env: UTILS_DIR: "${{github.workspace}}/utils" @@ -25,8 +28,9 @@ jobs: sudo apt-get install gcc-arm-linux-gnueabihf libfdt-dev device-tree-compiler gnutls-dev timeout-minutes: 15 - - uses: actions/checkout@v4 + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: + persist-credentials: false fetch-depth: 1 clean: true diff --git a/.github/workflows/kernel-build.yml b/.github/workflows/kernel-build.yml index cb6a8e5667c168..97c0ec7d871ae1 100644 --- a/.github/workflows/kernel-build.yml +++ b/.github/workflows/kernel-build.yml @@ -11,6 +11,9 @@ on: branches: [ "rpi-*" ] workflow_dispatch: +permissions: + contents: read + env: NUM_JOBS: 6 @@ -72,8 +75,9 @@ jobs: sudo apt-get install -y gcc-arm-linux-gnueabihf timeout-minutes: 15 - - uses: actions/checkout@v4 + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: + persist-credentials: false fetch-depth: 1 clean: true @@ -103,7 +107,7 @@ jobs: run: tar -cvf ${{matrix.name}}_build.tar -C ${{github.workspace}}/install . - name: Upload results - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 with: name: ${{matrix.name}}_build path: ${{matrix.name}}_build.tar diff --git a/.github/workflows/kunit.yml b/.github/workflows/kunit.yml index 1244d728974069..2ffa34f306d5c0 100644 --- a/.github/workflows/kunit.yml +++ b/.github/workflows/kunit.yml @@ -7,13 +7,18 @@ on: push: branches: [ "rpi-*"] +permissions: + contents: read + jobs: core: name: Generic DRM/KMS Unit Tests runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false - name: Run Generic DRM Tests run: | @@ -25,7 +30,9 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false - name: Install Dependencies run: | @@ -43,7 +50,9 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + persist-credentials: false - name: Install Dependencies run: | From 6770f92ac8ad9389c3cfa601219d6c867e41ce73 Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Thu, 19 Nov 2026 16:05:09 +0000 Subject: [PATCH 2/2] workflows: Use the tree's checkpatch.pl for PR reviews webispy/checkpatch-action runs checkpatch.pl from its webispy/checkpatch Docker image, which was last built in February 2023. That copy is missing years of upstream changes, and still applies the networking block comment rule dropped in commit 82b8000c28b5 ("net: drop special comment style"), so it reports warnings that local runs don't. Point the action's CHECKPATCH_COMMAND at the PR's own scripts/checkpatch.pl so each branch is checked against its own rules. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Phil Elwell --- .github/workflows/checkpatch.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/checkpatch.yml b/.github/workflows/checkpatch.yml index 8c162747eb8fe4..f5717ae624172e 100644 --- a/.github/workflows/checkpatch.yml +++ b/.github/workflows/checkpatch.yml @@ -19,4 +19,7 @@ jobs: - name: Copy checkpatch.conf run: cp ${{github.workspace}}/.github/workflows/ci_checkpatch.conf ${{github.workspace}}/.checkpatch.conf - name: Run checkpatch review + env: + # Use the tree's checkpatch.pl, not the action image's stale copy + CHECKPATCH_COMMAND: perl scripts/checkpatch.pl uses: webispy/checkpatch-action@58374fe5bb03358b23d3d6871e2ff290ce77fcd2 # v9