Skip to content

Commit 9485e8e

Browse files
committed
refactor: simplify isClickOnInput condition
1 parent 61d253b commit 9485e8e

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

src/SelectInput/index.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,7 @@ export default React.forwardRef<SelectInputRef, SelectInputProps>(function Selec
180180
// so we need to mark the event directly
181181
(event.nativeEvent as any)._ori_target = inputDOM;
182182

183-
const target = event.target;
184-
185-
const isClickOnInput =
186-
inputDOM && target && (target === inputDOM || inputDOM.contains(target as Node));
183+
const isClickOnInput = inputDOM === event.target || inputDOM?.contains(event.target as Node);
187184

188185
if (inputDOM && !isClickOnInput) {
189186
event.preventDefault();
@@ -195,7 +192,7 @@ export default React.forwardRef<SelectInputRef, SelectInputProps>(function Selec
195192
triggerOpen && !multiple && (mode === 'combobox' || showSearch);
196193

197194
// Don't close if: open && multiple && click on input
198-
const shouldPreventCloseOnMultipleInput = triggerOpen && !!multiple && isClickOnInput;
195+
const shouldPreventCloseOnMultipleInput = triggerOpen && multiple && isClickOnInput;
199196

200197
const shouldPreventClose = shouldPreventCloseOnSingle || shouldPreventCloseOnMultipleInput;
201198

0 commit comments

Comments
 (0)