fix: some edge cases

Author: jorisre

bin/cli.ts

@@ -92,8 +92,8 @@ function runTransform({ files, flags, transformer }) {
 
 const TRANSFORMER_INQUIRER_CHOICES = [
   {
-    name: 'register-migration: Transforms register',
-    value: 'register-migration'
+    name: 'v7/update-register: Transforms register api from v6 to v7',
+    value: 'v7/update-register'
   }
 ];
 

transforms/__testfixtures__/v7/update-register/function-component.input.js

@@ -7,6 +7,10 @@ function Input() {
 const Form = () => {
   const { register } = useForm();
 
+  useEffect(() => {
+    register('example');
+  }, [register]);
+
   return (
     <form>
       <input ref={register({ required: true })} name="example" />

transforms/__testfixtures__/v7/update-register/function-component.output.js

@@ -7,6 +7,10 @@ function Input() {
 const Form = () => {
   const { register } = useForm();
 
+  useEffect(() => {
+    register('example');
+  }, [register]);
+
   return (
     <form>
       <input {...register('example', { required: true })} />

transforms/v7/update-register.ts

@@ -61,22 +61,18 @@ export default function transformer(file: FileInfo, api: API, options) {
        *  const { register } = useForm();
        *          ^
        * */
-      const registerProperties = j(useFormDeclarator).find(j.Property, {
-        key: { name: REGISTER }
+      const registerProperties = j(useFormDeclarator).find(j.Identifier, {
+        name: REGISTER
       });
 
       registerProperties.forEach((registerProperty) => {
-        if (registerProperty.value.value.type !== 'Identifier') {
-          return;
-        }
-
         /**
          * Retrieve `register` property name
          * @example
          *  const { register } = useForm();
          *  const { register: registerCustomName } = useForm();
          * */
-        const register = registerProperty.value.value.name;
+        const register = registerProperty.parentPath.value.value.name;
 
         /**
          * Retrieve the related parent component
@@ -111,21 +107,25 @@ export default function transformer(file: FileInfo, api: API, options) {
                 return;
               }
 
-              const jsxAttribute = isCallExpression
+              const maybeJsxAttribute = isCallExpression
                 ? registerIdentifier.parent.parent.parent
                 : registerIdentifier.parent.parent;
 
-              if (jsxAttribute.value.name.name !== 'ref') return;
-
-              const jsxOpeningElement = j(jsxAttribute.parentPath);
+              if (maybeJsxAttribute.value.name?.name !== 'ref') return;
 
+              const jsxOpeningElement = j(maybeJsxAttribute.parentPath);
               // We search for all `name` attribute of the JSX element
               const nameAttributes = jsxOpeningElement.find(j.JSXAttribute, {
                 name: { name: 'name' }
               });
 
               nameAttributes.forEach((nameAttribute) => {
-                if (nameAttribute.value.value.type !== 'Literal') return;
+                if (
+                  nameAttribute.value.value.type !== 'Literal' &&
+                  nameAttribute.value.value.type !== 'StringLiteral'
+                ) {
+                  return;
+                }
 
                 const name = nameAttribute.value.value.value;
                 /**
@@ -152,7 +152,7 @@ export default function transformer(file: FileInfo, api: API, options) {
               });
 
               // We remove the old `ref` attribute
-              j(jsxAttribute).remove();
+              j(maybeJsxAttribute).remove();
             });
           });
       });

tsconfig.json

@@ -10,5 +10,5 @@
     "outDir": "dist"
   },
   "include": ["**/*.ts"],
-  "exclude": ["node_modules", "transforms/__tests__"]
+  "exclude": ["node_modules", "transforms/__tests__", "dist"]
 }