Skip to content

Commit 3ec798f

Browse files
committed
fix(useMediaQuery): remove asymmetric addListener/removeListener fallback in unsubscribe
createQueryEntry uses addEventListener unconditionally, but queryUnsubscribe still had a removeEventListener/removeListener fallback. This asymmetry is unnecessary since all supported browsers now have addEventListener on MediaQueryList.
1 parent 9719684 commit 3ec798f

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

src/useMediaQuery/index.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,7 @@ const queryUnsubscribe = (query: string, setState: QueryStateSetter): void => {
4747
if (dispatchers.size === 0) {
4848
queriesMap.delete(query);
4949

50-
if (mql.removeEventListener) {
51-
mql.removeEventListener('change', listener);
52-
} else {
53-
mql.removeListener(listener);
54-
}
50+
mql.removeEventListener('change', listener);
5551
}
5652
}
5753
};

0 commit comments

Comments
 (0)