Clean up legacy rn_inspector entry point (#236)

Author: huntie

README.md

@@ -48,7 +48,7 @@ This can then be served from a static web server to test locally:
 python3 -m http.server 8000 --directory out/Default/gen/front_end
 ```
 
-The frontend will be available at `http://localhost:8000/inspector.html` (or `http://localhost:8000/rn_inspector.html` for the RN-specific entry point).
+The frontend will be available at `http://localhost:8000/inspector.html` (or `http://localhost:8000/rn_fusebox.html` for the RN-specific entry point).
 
 ### Syncing with the upstream repo
 

config/gni/devtools_grd_files.gni

@@ -374,7 +374,6 @@ grd_files_release_sources = [
   "front_end/entrypoints/node_app/node_app.js",
   "front_end/entrypoints/rehydrated_devtools_app/rehydrated_devtools_app.js",
   "front_end/entrypoints/rn_fusebox/rn_fusebox.js",
-  "front_end/entrypoints/rn_inspector/rn_inspector.js",
   "front_end/entrypoints/shell/shell.js",
   "front_end/entrypoints/wasmparser_worker/wasmparser_worker-entrypoint.js",
   "front_end/entrypoints/wasmparser_worker/wasmparser_worker.js",
@@ -681,7 +680,6 @@ grd_files_release_sources = [
   "front_end/panels/recorder/recorder-meta.js",
   "front_end/panels/recorder/recorder.js",
   "front_end/panels/recorder/util/util.js",
-  "front_end/panels/rn_welcome/rn_welcome-legacy-meta.js",
   "front_end/panels/rn_welcome/rn_welcome-meta.js",
   "front_end/panels/rn_welcome/rn_welcome.js",
   "front_end/panels/screencast/screencast-meta.js",
@@ -721,7 +719,6 @@ grd_files_release_sources = [
   "front_end/panels/whats_new/whats_new.js",
   "front_end/rehydrated_devtools_app.html",
   "front_end/rn_fusebox.html",
-  "front_end/rn_inspector.html",
   "front_end/services/puppeteer/puppeteer.js",
   "front_end/services/trace_bounds/trace_bounds.js",
   "front_end/services/tracing/tracing.js",

front_end/BUILD.gn

@@ -28,7 +28,6 @@ group("front_end") {
     "entrypoints/node_app:entrypoint",
     "entrypoints/rehydrated_devtools_app:entrypoint",
     "entrypoints/rn_fusebox:entrypoint",
-    "entrypoints/rn_inspector:entrypoint",
     "entrypoints/shell",
     "entrypoints/wasmparser_worker:worker_entrypoint",
     "entrypoints/worker_app:entrypoint",
@@ -78,7 +77,6 @@ node_action("html_entrypoints") {
     "ndb_app",
     "node_app",
     "rn_fusebox",
-    "rn_inspector",
     "rehydrated_devtools_app",
     "worker_app",
     "device_mode_emulation_frame",

front_end/core/host/RNPerfMetrics.ts

@@ -25,7 +25,7 @@ class RNPerfMetrics {
   #listeners = new Set<RNReliabilityEventListener>();
   #launchId: string|null = null;
   #appId: string|null = null;
-  #entryPoint: EntryPoint = 'rn_inspector';
+  #entryPoint: EntryPoint = 'rn_fusebox';
   #telemetryInfo: Object = {};
   // map of panel location to panel name
   #currentPanels = new Map<PanelLocation, string>();
@@ -381,7 +381,7 @@ function maybeWrapError(baseMessage: string, error: unknown): [string, Error] {
   return [message, new Error(message, {cause: error})];
 }
 
-type EntryPoint = 'rn_fusebox'|'rn_inspector';
+type EntryPoint = 'rn_fusebox';
 
 type CommonEventFields = Readonly<{
   timestamp: DOMHighResTimeStamp,

front_end/core/rn_experiments/BUILD.gn

@@ -25,7 +25,6 @@ devtools_entrypoint("bundle") {
 
   visibility = [
     "../../entrypoints/rn_fusebox:*",
-    "../../entrypoints/rn_inspector:*",
     "../../entrypoints/main:*",
   ]
 }

front_end/core/rn_experiments/experimentsImpl.ts

@@ -24,8 +24,8 @@
 // - define it in the RNExperiments enum and Experiments enum (in Runtime.ts)
 // - register it in this file (rn_experiments.ts)
 //   - set `enabledByDefault` as appropriate
-// - optionally, configure it further in each RN-specific entry point
-//   (rn_inspector.ts, rn_fusebox.ts)
+// - optionally, configure it further in the RN-specific entry point
+//   (rn_fusebox.ts)
 //
 // React Native-specific experiments are merged into the main ExperimentsSupport
 // object in MainImpl and can't be configured further afterwards (except

front_end/entrypoints/inspector_main/BUILD.gn

@@ -71,7 +71,6 @@ devtools_entrypoint("meta") {
     "../devtools_app/*",
     "../rehydrated_devtools_app/*",
     "../rn_fusebox:*",
-    "../rn_inspector:*",
   ]
 }
 

front_end/entrypoints/main/BUILD.gn

@@ -57,7 +57,6 @@ devtools_entrypoint("bundle") {
     "../node_app:*",
     "../rehydrated_devtools_app:*",
     "../rn_fusebox:*",
-    "../rn_inspector:*",
     "../worker_app:*",
   ]