Skip to content

Commit 6ebb129

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Let visual capture deep-link when RNTester restores another screen (#59488)
Summary: Visual capture on main (run https://github.com/react/react-native/actions/runs/40319678403) failed almost every iOS flow at the shared "Components is visible" precondition, including retries. The helper currently requires RNTester to show its home screen before sending a direct example deep link. A relaunched app can instead restore another screen. Send the deep link immediately after launch; each flow already waits for and asserts its target example before taking screenshots. This lets later flows recover if an earlier flow leaves the app off the home screen. The first border flow also failed at an example assertion, so this change may not resolve all failures in that run. iOS capture CI is needed to verify the behavior. ## Changelog: [INTERNAL] [FIXED] - Allow visual capture to recover from RNTester reopening away from the home screen. Pull Request resolved: #59488 Test Plan: - `yarn test .github/workflow-scripts/__tests__/visual-capture-test.js --runInBand` — 10 tests passed. - `yarn prettier --check packages/rn-tester/visual-tests/helpers/open-example.yml` — passed. - `git diff --check` — passed. - iOS visual capture could not be run locally; verify on draft PR CI. Reviewed By: christophpurrer Differential Revision: D127578936 Pulled By: cortinico fbshipit-source-id: 91a6c9108e8e2dcb19d0fb77eb9c4eb1d306557a
1 parent 7206dcc commit 6ebb129

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

‎packages/rn-tester/visual-tests/helpers/open-example.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebo
22
---
33
- launchApp:
44
stopApp: true
5-
- extendedWaitUntil:
6-
visible: 'Components'
7-
timeout: 30000
85
- openLink: ${EXAMPLE_URL}
96
- runFlow:
107
when:

0 commit comments

Comments
 (0)