Require constant initialization for native static state (#59489)

Summary:
Pull Request resolved: #59489

Enforce constant initialization for eligible native globals, static defaults, synchronization primitives, and thread-local state without changing their mutability or lifetime.

Changelog: [Internal]

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D127576609

fbshipit-source-id: dca8d92a1187f92d204b252764b370239358c028

Author: javache

packages/react-native/Libraries/Image/RCTImageLoader.mm

@@ -32,7 +32,7 @@ static NSInteger RCTImageBytesForImage(UIImage *image)
   return image.images ? image.images.count * singleImageBytes : singleImageBytes;
 }
 
-static auto currentRequestCount = std::atomic<uint64_t>(0);
+static constinit auto currentRequestCount = std::atomic<uint64_t>(0);
 
 static NSError *addResponseHeadersToError(NSError *originalError, NSHTTPURLResponse *response)
 {

packages/react-native/Libraries/Network/RCTNetworkTask.mm

@@ -21,7 +21,7 @@ @implementation RCTNetworkTask {
   RCTNetworkTask *_selfReference;
 }
 
-static auto currentRequestId = std::atomic<NSUInteger>(0);
+static constinit auto currentRequestId = std::atomic<NSUInteger>(0);
 
 - (instancetype)initWithRequest:(NSURLRequest *)request
                         handler:(id<RCTURLRequestHandler>)handler

packages/react-native/React/Base/RCTUtils.mm

@@ -386,7 +386,7 @@ UIDeviceOrientation RCTDeviceOrientation(void)
 
 CGSize RCTScreenSize(void)
 {
-  static std::atomic<CGSize> cachedSize;
+  static constinit std::atomic<CGSize> cachedSize;
   __block CGSize size = cachedSize.load(std::memory_order_relaxed);
 
   if (CGSizeEqualToSize(size, CGSizeZero)) {

packages/react-native/React/CoreModules/RCTDevSettings.mm

@@ -127,7 +127,7 @@ - (void)_reloadWithDefaults:(NSDictionary *)defaultValues
 #if RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION
 static RCTHandlerToken reloadToken;
 static RCTHandlerToken devMenuToken;
-static std::atomic<int> numInitializedModules{0};
+static constinit std::atomic<int> numInitializedModules{0};
 #endif
 
 @interface RCTDevSettings () <RCTBridgeModule, RCTInvalidating, NativeDevSettingsSpec, RCTDevSettingsInspectable> {

packages/react-native/ReactAndroid/src/main/jni/first-party/fbgloginit/glog_init.cpp

@@ -112,7 +112,7 @@ lastResort(const char* tag, const char* msg, const char* arg = nullptr) {
 namespace facebook::gloginit {
 
 void initialize(const char* tag) {
-  static std::once_flag flag{};
+  static constinit std::once_flag flag{};
   static auto failed = false;
 
   std::call_once(flag, [tag] {

packages/react-native/ReactAndroid/src/main/jni/react/hermes/reactexecutor/OnLoad.cpp

@@ -25,7 +25,7 @@ static void hermesFatalHandler(const std::string& reason) {
   __android_log_assert(nullptr, "Hermes", "%s", reason.c_str());
 }
 
-static std::once_flag flag;
+static constinit std::once_flag flag;
 
 static ::hermes::vm::RuntimeConfig makeRuntimeConfig(jlong heapSizeMB) {
   namespace vm = ::hermes::vm;

packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.cpp

@@ -18,7 +18,7 @@ const int kInstanceKey = 1;
 }
 
 void JReactMarker::setLogPerfMarkerIfNeeded() {
-  static std::once_flag flag{};
+  static constinit std::once_flag flag{};
   std::call_once(flag, []() {
     ReactMarker::logTaggedMarkerImpl = JReactMarker::logPerfMarker;
   });

packages/react-native/ReactAndroid/src/main/jni/react/jni/SafeReleaseJniRef.cpp

@@ -20,7 +20,7 @@ void ensureThreadDurationJNIEnvAttached() {
   // > exits, and call DetachCurrentThread() from there.
   // https://github.com/facebookincubator/fbjni/blob/7b7efda0d49b956acf1d3307510e3c73fc55b404/cxx/fbjni/detail/Environment.h#L101
   // https://developer.android.com/training/articles/perf-jni#threads
-  static thread_local std::optional<jni::ThreadScope> threadScope;
+  static constinit thread_local std::optional<jni::ThreadScope> threadScope;
 
   if (jni::detail::currentOrNull() == nullptr) {
     threadScope.emplace();

packages/react-native/ReactCommon/cxxreact/TraceSection.h

@@ -168,7 +168,7 @@ inline os_log_t instrumentsLogHandle = nullptr;
 
 static inline os_log_t getOrCreateInstrumentsLogHandle()
 {
-  static std::once_flag flag{};
+  static constinit std::once_flag flag{};
   std::call_once(flag, []() {
     if (!instrumentsLogHandle) {
       instrumentsLogHandle = os_log_create("dev.reactnative.instruments", OS_LOG_CATEGORY_DYNAMIC_TRACING);

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<e54d2f7c5761d2bdb0edff1065896eb2>>
+ * @generated SignedSource<<56e127471f63e47798ec619e6fa56738>>
  */
 
 /**
@@ -23,7 +23,7 @@ namespace facebook::react {
 
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wglobal-constructors"
-std::unique_ptr<ReactNativeFeatureFlagsAccessor> accessor_;
+constinit std::unique_ptr<ReactNativeFeatureFlagsAccessor> accessor_;
 #pragma GCC diagnostic pop
 
 bool ReactNativeFeatureFlags::commonTestFlag() {