Restore Fantom DevTools launching with FANTOM_DEBUG_JS (#59410)

Summary:

Restore DevTools launching when `FANTOM_DEBUG_JS` is set by allowing the existing native tester to launch through the shared browser launcher. Explicitly allow app launching for interactive test debugging, use a Chrome app window instead of the standalone shell, and run debugging sessions in band.

Changelog: [Internal]

Reviewed By: lenaic, andrewdacenko

Differential Revision: D127171074

Author: rubennorte

packages/dev-middleware/src/utils/DefaultToolLauncher.js

@@ -23,8 +23,13 @@ const {apps, openApp} = open;
  * local machine.
  */
 const DefaultToolLauncher = {
-  launchDebuggerAppWindow: async (url: string): Promise<void> => {
-    if (process.env.NODE_ENV === 'test') {
+  launchDebuggerAppWindow: async (
+    url: string,
+    options?: Readonly<{
+      allowInTests?: boolean,
+    }>,
+  ): Promise<void> => {
+    if (process.env.NODE_ENV === 'test' && options?.allowInTests !== true) {
       assertMockedInTests();
     }
 

private/react-native-fantom/runner/global-setup/globalSetup.js

@@ -10,10 +10,17 @@
 
 import type {DevToolLauncher} from '@react-native/dev-middleware';
 
-import {isOSS, validateEnvironmentVariables} from '../EnvironmentOptions';
+import {
+  debugJS,
+  isOSS,
+  validateEnvironmentVariables,
+} from '../EnvironmentOptions';
 import {getTestBuildOutputPath} from '../paths';
 import build from './build';
-import {createDevMiddleware} from '@react-native/dev-middleware';
+import {
+  createDevMiddleware,
+  unstable_DefaultToolLauncher as DefaultToolLauncher,
+} from '@react-native/dev-middleware';
 import * as Metro from 'metro';
 import {Server} from 'node:net';
 import path from 'node:path';
@@ -55,19 +62,26 @@ async function startMetroServer() {
   // $FlowExpectedError[cannot-write]
   metroConfig.server.port = Number(process.env.__FANTOM_METRO_PORT__);
 
-  // No-op app launcher to prevent debugger-shell launches during tests
+  const serverBaseUrl = `http://localhost:${metroConfig.server.port}`;
   const devToolLauncher: DevToolLauncher = {
-    launchDebuggerAppWindow: async (_url: string) => {},
-    launchDebuggerShell: async () => {},
-    prepareDebuggerShell: async () => ({code: 'not_implemented'}),
+    launchDebuggerAppWindow: async (url: string) => {
+      if (debugJS) {
+        await DefaultToolLauncher.launchDebuggerAppWindow(url, {
+          allowInTests: true,
+        });
+      }
+    },
   };
 
   const {
     middleware: devMiddleware,
     websocketEndpoints: debuggerWebsocketEndpoints,
   } = createDevMiddleware({
-    serverBaseUrl: `http://localhost:${metroConfig.server.port}`,
+    serverBaseUrl,
     unstable_toolLauncher: devToolLauncher,
+    unstable_experiments: {
+      enableStandaloneFuseboxShell: false,
+    },
   });
 
   const server = await Metro.runServer(metroConfig, {

scripts/fantom.sh

@@ -33,7 +33,7 @@ for arg in "$@"; do
   esac
 done
 
-if [[ -n "$FANTOM_RUN_BENCHMARKS" ]]; then
+if [[ -n "$FANTOM_RUN_BENCHMARKS" || -n "$FANTOM_DEBUG_JS" ]]; then
   ARGS+=("--runInBand")
 fi