Reland iOS 27 StatusBar fix with tvOS guards (#58926)

Summary:
Fixes #58758.

Apps built with the iOS 27 SDK can no longer change the status bar through the `UIApplication` setters. Restore the view-controller-based implementation: `RCTStatusBarAppearance` stores the requested style, hidden state and animation, and the default root and Fabric modal controllers return those values. The modal preserves the appearance captured before presentation until JavaScript changes it.

Apps must set `UIViewControllerBasedStatusBarAppearance` to `YES` on iOS 27. Custom root view controllers must return the `RCTStatusBarAppearance` values. Apps using `NO` retain the legacy setters on older SDKs and receive a one-time warning where those setters are ineffective.

Exclude the appearance helper and status-bar controller code on tvOS, where UIKit's status-bar types and APIs are unavailable. Guard the modal capture declaration and call as well as its state and implementation. The iOS code paths are unchanged.


Test Plan:
- Built the full `AirwaveBurbn` app and package for appletvos-arm64 with the Airwave mode, local build flavour, Pika 27 and Xcode 27.1. Code signing was skipped for local validation. Both targets passed. Buck run: https://www.internalfb.com/buck2/9c21f926-63ea-4fd5-8370-286f70fc829b.
- Built `ReactApple`, `RCTFabricApple` and `RCTAppDelegateApple` with `AirwavePlatform-appletvos-arm64-local`. All passed. Buck run: https://www.internalfb.com/buck2/0aaabc5f-e893-4d9d-8ce1-a346c3315bbf.
- Built `ReactApple`, `CoreModulesApple`, `RCTFabricApple` and `RCTAppDelegateApple` for iphonesimulator-arm64. All passed. Buck run: https://www.internalfb.com/buck2/876de6d7-fbd8-439f-bdbe-d4fed3d29a91.
- Regenerated all C++ API snapshots. Only the four ReactApple snapshots changed, each adding `RCTStatusBarAppearance`; no private API appeared. Ran the snapshot target with `--validate`; all 12 snapshots passed. Validation run: https://www.internalfb.com/buck2/a8fc85da-ba96-4b3b-a741-afede29b5f0d.
- Meta-managed clang-format, `arc f` and `arc lint` passed.
- Independent read-only review found no blockers in the tvOS guards and confirmed that the iOS implementation matches the original landed change apart from platform guards.
- Restored the original 12 `RCTStatusBarAppearanceTests` XCTest cases. These remain registered in the OSS Xcode test target, have no internal Buck owner, and were not run locally. No simulator runtime verification was performed.
- The manual Sandcastle smoke launcher defaulted to iphoneos rather than appletvos. Its build and baseline retry failed target-compatibility checks before compiling. Do not count the launcher success as a passing tvOS build; the full tvOS validation is the local Buck run above. Child run: https://www.internalfb.com/intern/sandcastle/instance/40532397437851209/.
- Diff-time CI currently has a non-bypassable `github-export-checks` failure because this new diff has no linked/exported GitHub PR. Export at https://www.internalfb.com/intern/opensource/export/preview/D127817413/ and rerun the check before landing. Other CI jobs are still running.
- General Reviewer flagged a modal-state edge case also present in the original patch: changing a JS status-bar value and then returning to its capture-time value can restore the pre-modal native appearance. That warning remains unresolved for review; this re-land deliberately preserves the original iOS behaviour.

Differential Revision: D127817413

Pulled By: cipolleschi

Author: alanjhughes

packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm

@@ -14,9 +14,34 @@
 #endif
 
 #import <RCTAnimatedModuleProvider/RCTAnimatedModuleProvider.h>
+#import <React/RCTStatusBarAppearance.h>
 #import <react/featureflags/ReactNativeFeatureFlags.h>
 #import <react/nativemodule/defaults/DefaultTurboModules.h>
 
+@interface RCTRootViewController : UIViewController
+@end
+
+@implementation RCTRootViewController
+
+#if !TARGET_OS_TV
+- (UIStatusBarStyle)preferredStatusBarStyle
+{
+  return RCTStatusBarAppearance.style;
+}
+
+- (BOOL)prefersStatusBarHidden
+{
+  return RCTStatusBarAppearance.hidden;
+}
+
+- (UIStatusBarAnimation)preferredStatusBarUpdateAnimation
+{
+  return RCTStatusBarAppearance.updateAnimation;
+}
+#endif
+
+@end
+
 @implementation RCTDefaultReactNativeFactoryDelegate {
   // C++ Native Animated provider, created once on first use (getTurboModule: may be called
   // concurrently for different module names).
@@ -35,7 +60,7 @@ - (NSURL *_Nullable)sourceURLForBridge:(nonnull RCTBridge *)bridge
 
 - (UIViewController *)createRootViewController
 {
-  return [UIViewController new];
+  return [RCTRootViewController new];
 }
 
 - (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController

packages/react-native/Libraries/AppDelegate/RCTUIConfiguratorProtocol.h

@@ -41,7 +41,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 /**
  * It creates the RootViewController.
- * By default, it creates a new instance of a `UIViewController`.
+ * By default, it creates a view controller that returns the `RCTStatusBarAppearance` values.
  * You can override it to provide your own initial ViewController.
  *
  * @return: an instance of `UIViewController`.

packages/react-native/React/Base/RCTStatusBarAppearance.h

@@ -0,0 +1,28 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#import <UIKit/UIKit.h>
+
+#if !TARGET_OS_TV
+NS_ASSUME_NONNULL_BEGIN
+
+/**
+ * The status bar state set from JavaScript. Root view controllers return these values from their status bar methods.
+ */
+@interface RCTStatusBarAppearance : NSObject
+
+@property (class, nonatomic, readonly) UIStatusBarStyle style;
+@property (class, nonatomic, readonly) BOOL hidden;
+@property (class, nonatomic, readonly) UIStatusBarAnimation updateAnimation;
+
++ (void)setStyle:(UIStatusBarStyle)style animated:(BOOL)animated;
++ (void)setHidden:(BOOL)hidden withAnimation:(UIStatusBarAnimation)animation;
+
+@end
+
+NS_ASSUME_NONNULL_END
+#endif

packages/react-native/React/Base/RCTStatusBarAppearance.mm

@@ -0,0 +1,64 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#import "RCTStatusBarAppearance.h"
+
+#if !TARGET_OS_TV
+#import "RCTAssert.h"
+#import "RCTUtils.h"
+
+static UIStatusBarStyle sStyle = UIStatusBarStyleDefault;
+static BOOL sHidden = NO;
+static UIStatusBarAnimation sUpdateAnimation = UIStatusBarAnimationNone;
+
+@implementation RCTStatusBarAppearance
+
++ (UIStatusBarStyle)style
+{
+  return sStyle;
+}
+
++ (BOOL)hidden
+{
+  return sHidden;
+}
+
++ (UIStatusBarAnimation)updateAnimation
+{
+  return sUpdateAnimation;
+}
+
++ (void)setStyle:(UIStatusBarStyle)style animated:(BOOL)animated
+{
+  RCTAssertMainQueue();
+  sStyle = style;
+  [self updateStatusBarAnimated:animated];
+}
+
++ (void)setHidden:(BOOL)hidden withAnimation:(UIStatusBarAnimation)animation
+{
+  RCTAssertMainQueue();
+  sHidden = hidden;
+  sUpdateAnimation = animation;
+  [self updateStatusBarAnimated:animation != UIStatusBarAnimationNone];
+}
+
++ (void)updateStatusBarAnimated:(BOOL)animated
+{
+  UIViewController *viewController = RCTPresentedViewController();
+  if (animated) {
+    [UIView animateWithDuration:UINavigationControllerHideShowBarDuration
+                     animations:^{
+                       [viewController setNeedsStatusBarAppearanceUpdate];
+                     }];
+  } else {
+    [viewController setNeedsStatusBarAppearanceUpdate];
+  }
+}
+
+@end
+#endif

packages/react-native/React/CoreModules/RCTStatusBarManager.mm

@@ -11,6 +11,7 @@
 #import <React/RCTEventDispatcherProtocol.h>
 #import <React/RCTInitializing.h>
 #import <React/RCTLog.h>
+#import <React/RCTStatusBarAppearance.h>
 #import <React/RCTUtils.h>
 
 #import <FBReactNativeSpec/FBReactNativeSpec.h>
@@ -68,6 +69,28 @@ static BOOL RCTViewControllerBasedStatusBarAppearance()
   return value;
 }
 
+// UIKit makes the app-level setters no-ops only for apps built with the iOS 27 SDK.
+static BOOL RCTAppLevelStatusBarIsNoOp()
+{
+#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 270000
+  if (@available(iOS 27.0, *)) {
+    return YES;
+  }
+#endif
+  return NO;
+}
+
+static void RCTWarnAppLevelStatusBarUnavailable()
+{
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    RCTLogWarn(
+        @"StatusBar has no effect because UIViewControllerBasedStatusBarAppearance is NO in Info.plist. "
+        @"Apps built with the iOS 27 SDK cannot use the app-level status bar API that this setting uses. "
+        @"Set UIViewControllerBasedStatusBarAppearance to YES to control the status bar from JavaScript.");
+  });
+}
+
 RCT_EXPORT_MODULE()
 
 + (BOOL)requiresMainQueueSetup
@@ -147,30 +170,32 @@ - (void)setStyle:(NSString *)style animated:(BOOL)animated
 {
   dispatch_async(dispatch_get_main_queue(), ^{
     UIStatusBarStyle statusBarStyle = [RCTConvert UIStatusBarStyle:style];
-    if (RCTViewControllerBasedStatusBarAppearance()) {
-      RCTLogWarn(@"RCTStatusBarManager is a no-op when \
-                UIViewControllerBasedStatusBarAppearance is YES; set the status bar from your view controller instead");
-    } else {
+    [RCTStatusBarAppearance setStyle:statusBarStyle animated:animated];
+    if (!RCTViewControllerBasedStatusBarAppearance()) {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
       [RCTSharedApplication() setStatusBarStyle:statusBarStyle animated:animated];
-    }
 #pragma clang diagnostic pop
+      if (RCTAppLevelStatusBarIsNoOp()) {
+        RCTWarnAppLevelStatusBarUnavailable();
+      }
+    }
   });
 }
 
 - (void)setHidden:(BOOL)hidden withAnimation:(NSString *)withAnimation
 {
   dispatch_async(dispatch_get_main_queue(), ^{
     UIStatusBarAnimation animation = [RCTConvert UIStatusBarAnimation:withAnimation];
-    if (RCTViewControllerBasedStatusBarAppearance()) {
-      RCTLogWarn(@"RCTStatusBarManager is a no-op when \
-                UIViewControllerBasedStatusBarAppearance is YES; set the status bar from your view controller instead");
-    } else {
+    [RCTStatusBarAppearance setHidden:hidden withAnimation:animation];
+    if (!RCTViewControllerBasedStatusBarAppearance()) {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
       [RCTSharedApplication() setStatusBarHidden:hidden withAnimation:animation];
 #pragma clang diagnostic pop
+      if (RCTAppLevelStatusBarIsNoOp()) {
+        RCTWarnAppLevelStatusBarUnavailable();
+      }
     }
   });
 }

packages/react-native/React/Fabric/Mounting/ComponentViews/Modal/RCTFabricModalHostViewController.mm

@@ -8,12 +8,18 @@
 #import "RCTFabricModalHostViewController.h"
 
 #import <React/RCTLog.h>
+#import <React/RCTStatusBarAppearance.h>
 #import <React/RCTSurfaceTouchHandler.h>
 
 @implementation RCTFabricModalHostViewController {
   CGRect _lastViewBounds;
 #if !TARGET_OS_TV
   RCTSurfaceTouchHandler *_touchHandler;
+  BOOL _hasCapturedStatusBar;
+  UIStatusBarStyle _capturedStatusBarStyle;
+  BOOL _capturedStatusBarHidden;
+  UIStatusBarStyle _jsStatusBarStyleAtCapture;
+  BOOL _jsStatusBarHiddenAtCapture;
 #endif
 }
 
@@ -47,14 +53,36 @@ - (void)loadView
 }
 
 #if !TARGET_OS_TV
+- (void)captureStatusBarAppearance
+{
+  UIStatusBarManager *statusBarManager = RCTUIStatusBarManager();
+  _hasCapturedStatusBar = YES;
+  _capturedStatusBarStyle = statusBarManager.statusBarStyle;
+  _capturedStatusBarHidden = statusBarManager.isStatusBarHidden;
+  _jsStatusBarStyleAtCapture = RCTStatusBarAppearance.style;
+  _jsStatusBarHiddenAtCapture = RCTStatusBarAppearance.hidden;
+}
+
+// Keep the status bar from before the modal until JS changes it.
 - (UIStatusBarStyle)preferredStatusBarStyle
 {
-  return [RCTUIStatusBarManager() statusBarStyle];
+  if (_hasCapturedStatusBar && RCTStatusBarAppearance.style == _jsStatusBarStyleAtCapture) {
+    return _capturedStatusBarStyle;
+  }
+  return RCTStatusBarAppearance.style;
 }
 
 - (BOOL)prefersStatusBarHidden
 {
-  return [RCTUIStatusBarManager() isStatusBarHidden];
+  if (_hasCapturedStatusBar && RCTStatusBarAppearance.hidden == _jsStatusBarHiddenAtCapture) {
+    return _capturedStatusBarHidden;
+  }
+  return RCTStatusBarAppearance.hidden;
+}
+
+- (UIStatusBarAnimation)preferredStatusBarUpdateAnimation
+{
+  return RCTStatusBarAppearance.updateAnimation;
 }
 #endif
 

packages/react-native/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm

@@ -17,6 +17,12 @@
 
 #import "RCTFabricModalHostViewController.h"
 
+#if !TARGET_OS_TV
+@interface RCTFabricModalHostViewController ()
+- (void)captureStatusBarAppearance;
+@end
+#endif
+
 using namespace facebook::react;
 
 #if !TARGET_OS_TV
@@ -173,6 +179,9 @@ - (void)ensurePresentedOnlyIfNeeded
     [self saveAccessibilityFocusedView];
     self.viewController.presentationController.delegate = self;
     self.viewController.modalInPresentation = _modalInPresentation;
+#if !TARGET_OS_TV
+    [self.viewController captureStatusBarAppearance];
+#endif
 
     _isPresented = YES;
     [self presentViewController:self.viewController

packages/rn-tester/RNTester/Info.plist

@@ -81,6 +81,6 @@
 		<string>UIInterfaceOrientationPortraitUpsideDown</string>
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
-	<false/>
+	<true/>
 </dict>
 </plist>

packages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj

@@ -17,6 +17,7 @@
 		5C60EB1C226440DB0018C04F /* AppDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C60EB1B226440DB0018C04F /* AppDelegate.mm */; };
 		602160B9478DAFF2BAB56595 /* RCTUtilsTests.m in Sources */ = {isa = PBXBuildFile; fileRef = D5D13FB1445C5C19639921CC /* RCTUtilsTests.m */; };
 		79B29C2E2E607A99007612A5 /* SceneDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 79B29C2D2E607A99007612A5 /* SceneDelegate.mm */; };
+		7F806D4D4D97AD6403558B35 /* RCTStatusBarAppearanceTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 67B0814814F7C07E196BC295 /* RCTStatusBarAppearanceTests.mm */; };
 		8145AE06241172D900A3F8DA /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 8145AE05241172D900A3F8DA /* LaunchScreen.storyboard */; };
 		832F45BB2A8A6E1F0097B4E6 /* SwiftTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 832F45BA2A8A6E1F0097B4E6 /* SwiftTest.swift */; };
 		A975CA6C2C05EADF0043F72A /* RCTNetworkTaskTests.m in Sources */ = {isa = PBXBuildFile; fileRef = A975CA6B2C05EADE0043F72A /* RCTNetworkTaskTests.m */; };
@@ -94,6 +95,7 @@
 		4C706D402EE4AF9BE838CBA9 /* libPods-RNTester.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-RNTester.a"; sourceTree = BUILT_PRODUCTS_DIR; };
 		51BC9297B6C3163C14532020 /* Pods-RNTester.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RNTester.release.xcconfig"; path = "Target Support Files/Pods-RNTester/Pods-RNTester.release.xcconfig"; sourceTree = "<group>"; };
 		5C60EB1B226440DB0018C04F /* AppDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AppDelegate.mm; path = RNTester/AppDelegate.mm; sourceTree = "<group>"; };
+		67B0814814F7C07E196BC295 /* RCTStatusBarAppearanceTests.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = RCTStatusBarAppearanceTests.mm; sourceTree = "<group>"; };
 		79B29C2C2E607A99007612A5 /* SceneDelegate.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SceneDelegate.h; path = RNTester/SceneDelegate.h; sourceTree = "<group>"; };
 		79B29C2D2E607A99007612A5 /* SceneDelegate.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = SceneDelegate.mm; path = RNTester/SceneDelegate.mm; sourceTree = "<group>"; };
 		8145AE05241172D900A3F8DA /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = RNTester/LaunchScreen.storyboard; sourceTree = "<group>"; };
@@ -350,6 +352,7 @@
 				E7DB20D022B2BAA5005AC45F /* RCTURLUtilsTests.m */,
 				D5D13FB1445C5C19639921CC /* RCTUtilsTests.m */,
 				E7DB20B322B2BAA4005AC45F /* RNTesterUnitTestsBundle.js */,
+				67B0814814F7C07E196BC295 /* RCTStatusBarAppearanceTests.mm */,
 			);
 			path = RNTesterUnitTests;
 			sourceTree = "<group>";
@@ -778,6 +781,7 @@
 				E7DB20E922B2BAA6005AC45F /* RCTComponentPropsTests.m in Sources */,
 				E7DB20D822B2BAA6005AC45F /* RCTJSONTests.m in Sources */,
 				602160B9478DAFF2BAB56595 /* RCTUtilsTests.m in Sources */,
+				7F806D4D4D97AD6403558B35 /* RCTStatusBarAppearanceTests.mm in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};