Skip to content

[BUG] Commands names violates documented convention #482

Description

@LeiYangGH

Describe the bug
The doc Command Names says:

Don't suffix ReactiveCommand properties' names with Command; instead, name the property using a verb that describes the command's action. For example:

public ReactiveCommand Synchronize { get; private set; }

But the sample code can find violations everywhere, just name a few:

CalculateCommand
https://github.com/reactiveui/ReactiveUI.Samples/blob/main/wpf/ReactiveUI.Samples.Basics/ViewModels/CalculatorViewModel.cs

StartAsyncCommand
https://github.com/reactiveui/ReactiveUI.Samples/blob/main/wpf/ReactiveUI.Samples.Commands/RxUI/MainVIewModel.cs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions