fix: prevent Process::close() double execution

7-zete-7 · 7-zete-7 · commit daadf8684949 · 2025-08-28T15:02:01.000+03:00
diff --git a/src/Process.php b/src/Process.php
@@ -297,6 +297,9 @@ public function close()
             return;
         }
 
+        $process = $this->process;
+        $this->process = null;
+
         foreach ($this->pipes as $pipe) {
             $pipe->close();
         }
@@ -306,8 +309,7 @@ public function close()
             $this->closeExitCodePipe();
         }
 
-        $exitCode = \proc_close($this->process);
-        $this->process = null;
+        $exitCode = \proc_close($process);
 
         if ($this->exitCode === null && $exitCode !== -1) {
             $this->exitCode = $exitCode;

Original file line number	Diff line number	Diff line change
`@@ -297,6 +297,9 @@ public function close()`
`297`	`297`	`return;`
`298`	`298`	`}`
`299`	`299`
	`300`	`+ $process = $this->process;`
	`301`	`+ $this->process = null;`
	`302`	`+`
`300`	`303`	`foreach ($this->pipes as $pipe) {`
`301`	`304`	`$pipe->close();`
`302`	`305`	`}`
`@@ -306,8 +309,7 @@ public function close()`
`306`	`309`	`$this->closeExitCodePipe();`
`307`	`310`	`}`
`308`	`311`
`309`		`- $exitCode = \proc_close($this->process);`
`310`		`- $this->process = null;`
	`312`	`+ $exitCode = \proc_close($process);`
`311`	`313`
`312`	`314`	`if ($this->exitCode === null && $exitCode !== -1) {`
`313`	`315`	`$this->exitCode = $exitCode;`