Unify chunked decoder and always skip trailers also for HTTP server

Remove dedicated client-side chunked decoder in favor of existing
server-side chunked decoder. Unify handling to always skip (unused)
trailers for both sides.

Author: clue

src/Client/ChunkedStreamDecoder.php

@@ -3,6 +3,7 @@
 namespace React\Http\Client;
 
 use Evenement\EventEmitter;
+use React\Http\Io\ChunkedDecoder;
 use React\Stream\ReadableStreamInterface;
 use React\Stream\Util;
 use React\Stream\WritableStreamInterface;
@@ -33,7 +34,7 @@ public function __construct(ReadableStreamInterface $stream, $protocol, $version
         $this->headers = $headers;
 
         if (strtolower($this->getHeaderLine('Transfer-Encoding')) === 'chunked') {
-            $this->stream = new ChunkedStreamDecoder($stream);
+            $this->stream = new ChunkedDecoder($stream);
             $this->removeHeader('Transfer-Encoding');
         }
 

src/Client/Response.php

@@ -116,7 +116,7 @@ public function handleData($data)
                 }
 
                 if ($hexValue !== '') {
-                    $hexValue = \ltrim($hexValue, "0");
+                    $hexValue = \ltrim(\trim($hexValue), "0");
                     if ($hexValue === '') {
                         $hexValue = "0";
                     }
@@ -155,16 +155,19 @@ public function handleData($data)
                 $this->headerCompleted = false;
                 $this->transferredSize = 0;
                 $this->buffer = (string)\substr($this->buffer, 2);
+            } elseif ($this->chunkSize === 0) {
+                // end chunk received, skip all trailer data
+                $this->buffer = (string)\substr($this->buffer, $positionCrlf);
             }
 
-            if ($positionCrlf !== 0 && $this->chunkSize === $this->transferredSize && \strlen($this->buffer) > 2) {
-                // the first 2 characters are not CLRF, send error event
-                $this->handleError(new Exception('Chunk does not end with a CLRF'));
+            if ($positionCrlf !== 0 && $this->chunkSize !== 0 && $this->chunkSize === $this->transferredSize && \strlen($this->buffer) > 2) {
+                // the first 2 characters are not CRLF, send error event
+                $this->handleError(new Exception('Chunk does not end with a CRLF'));
                 return;
             }
 
             if ($positionCrlf !== 0 && \strlen($this->buffer) < 2) {
-                // No CLRF found, wait for additional data which could be a CLRF
+                // No CRLF found, wait for additional data which could be a CRLF
                 return;
             }
         }