Skip to content

Commit 9d39c31

Browse files
committed
Added cascadeCreate parameter to merge users request
1 parent e950598 commit 9d39c31

5 files changed

Lines changed: 15 additions & 7 deletions

File tree

recombee_api_client/api_requests/merge_users.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class MergeUsers(Request):
99
1010
"""
1111

12-
def __init__(self,target_user_id, source_user_id, keep_source_user=None):
12+
def __init__(self,target_user_id, source_user_id, keep_source_user=None, cascade_create=None):
1313
"""
1414
Required parameters:
1515
@param target_user_id: ID of the source user.
@@ -18,12 +18,15 @@ def __init__(self,target_user_id, source_user_id, keep_source_user=None):
1818
1919
2020
Optional parameters:
21-
@param keep_source_user: If true, the source user will not be deleted, but also kept in the database..
21+
@param keep_source_user: If true, the source user will not be deleted, but also kept in the database.
22+
23+
@param cascade_create: Sets whether the user *targetUserId* should be created if not present in the database.
2224
2325
"""
2426
self.target_user_id = target_user_id
2527
self.source_user_id = source_user_id
2628
self.keep_source_user = keep_source_user
29+
self.cascade_create = cascade_create
2730
self.timeout = 1000
2831
self.ensure_https = False
2932
self.method = 'put'
@@ -43,4 +46,6 @@ def get_query_parameters(self):
4346
params = dict()
4447
if self.keep_source_user is not None:
4548
params['keepSourceUser'] = self.keep_source_user
49+
if self.cascade_create is not None:
50+
params['cascadeCreate'] = self.cascade_create
4651
return params

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
setup(
1212
name='recombee-api-client',
1313

14-
version='1.2.2',
14+
version='1.2.3',
1515

1616
description='Client for Recombee recommendation API',
1717
long_description=long_description,
@@ -60,4 +60,4 @@
6060
data_files=[],
6161

6262
entry_points={},
63-
)
63+
)

tests/test_cases/merge_users.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
class MergeUsersTest (RecombeeTest ):
1010

11-
def create_request(self,target_user_id,source_user_id,keep_source_user=None):
11+
def create_request(self,target_user_id,source_user_id,keep_source_user=None,cascade_create=None):
1212
pass
1313

1414
def test_merge_users(self):

tests/test_cases/set_values.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ def test_set_values(self):
1616
# it 'does not fail with existing entity and property'
1717
req = self.create_request('entity_id',{'int_property': 5})
1818
resp = self.client.send(req)
19+
# it 'does not fail with non-ASCII string'
20+
req = self.create_request('entity_id',{'str_property': 'šřžذ的‎'})
21+
resp = self.client.send(req)
1922
# it 'sets multiple properties'
2023
req = self.create_request('entity_id',{'int_property': 5,'str_property': 'test'})
2124
resp = self.client.send(req)

tests/test_cases/test_merge_users.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77

88
class MergeUsersTestCase (MergeUsersTest):
99

10-
def create_request(self, target_user_id, source_user_id, keep_source_user=None):
11-
return MergeUsers(target_user_id, source_user_id, keep_source_user=keep_source_user)
10+
def create_request(self, target_user_id, source_user_id, keep_source_user=None, cascade_create=None):
11+
return MergeUsers(target_user_id, source_user_id, keep_source_user=keep_source_user, cascade_create=cascade_create)

0 commit comments

Comments
 (0)